From: Guenter Roeck <linux@roeck-us.net>
To: Alex Hemme <ahemme@cisco.com>
Cc: jdelvare@suse.com, linux-hwmon@vger.kernel.org
Subject: Re: [PATCH] hwmon: (max31790) Set correct PWM value
Date: Tue, 7 Mar 2017 14:19:20 -0800 [thread overview]
Message-ID: <20170307221920.GA14619@roeck-us.net> (raw)
In-Reply-To: <1488915509-19547-1-git-send-email-ahemme@cisco.com>
On Tue, Mar 07, 2017 at 02:38:29PM -0500, Alex Hemme wrote:
> Traced fans not spinning to incorrect PWM value being written.
> The passed in value was written instead of the calulated value.
>
> Fixes: 54187ff9d766 ("hwmon: (max31790) Convert to use new hwmon registration API")
>
> Signed-off-by: Alex Hemme <ahemme@cisco.com>
Applied, and sorry for the trouble.
Thanks,
Guenter
> ---
> drivers/hwmon/max31790.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/max31790.c b/drivers/hwmon/max31790.c
> index c1b9275..281491c 100644
> --- a/drivers/hwmon/max31790.c
> +++ b/drivers/hwmon/max31790.c
> @@ -311,7 +311,7 @@ static int max31790_write_pwm(struct device *dev, u32 attr, int channel,
> data->pwm[channel] = val << 8;
> err = i2c_smbus_write_word_swapped(client,
> MAX31790_REG_PWMOUT(channel),
> - val);
> + data->pwm[channel]);
> break;
> case hwmon_pwm_enable:
> fan_config = data->fan_config[channel];
> --
> 1.8.3.1
>
prev parent reply other threads:[~2017-03-08 0:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-07 19:38 [PATCH] hwmon: (max31790) Set correct PWM value Alex Hemme
2017-03-07 22:19 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170307221920.GA14619@roeck-us.net \
--to=linux@roeck-us.net \
--cc=ahemme@cisco.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox