From: Javier Martinez Canillas <javier@osg.samsung.com>
To: linux-kernel@vger.kernel.org
Cc: Javier Martinez Canillas <javier@osg.samsung.com>,
linux-hwmon@vger.kernel.org, Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>
Subject: [PATCH v2 2/2] hwmon: (lm87) Add OF device ID table
Date: Wed, 12 Apr 2017 21:21:39 -0300 [thread overview]
Message-ID: <20170413002139.5983-2-javier@osg.samsung.com> (raw)
In-Reply-To: <20170413002139.5983-1-javier@osg.samsung.com>
The driver doesn't have a struct of_device_id table but supported devices
are registered via Device Trees. This is working on the assumption that a
I2C device registered via OF will always match a legacy I2C device ID and
that the MODALIAS reported will always be of the form i2c:<device>.
But this could change in the future so the correct approach is to have an
OF device ID table if the devices are registered via OF.
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
Hello,
I should had included this patch in series [0] but it seems that I didn't.
[0]: https://lkml.org/lkml/2017/2/24/360
Best regards,
Javier
Changes in v2:
- Use the correct driver in subject line.
- Keep OF device ID table sorted in the same order than I2C device ID table.
drivers/hwmon/lm87.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/hwmon/lm87.c b/drivers/hwmon/lm87.c
index c0766e7392d3..b48d30760388 100644
--- a/drivers/hwmon/lm87.c
+++ b/drivers/hwmon/lm87.c
@@ -985,10 +985,18 @@ static const struct i2c_device_id lm87_id[] = {
};
MODULE_DEVICE_TABLE(i2c, lm87_id);
+static const struct of_device_id lm87_of_match[] = {
+ { .compatible = "ti,lm87" },
+ { .compatible = "adi,adm1024" },
+ { },
+};
+MODULE_DEVICE_TABLE(of, lm87_of_match);
+
static struct i2c_driver lm87_driver = {
.class = I2C_CLASS_HWMON,
.driver = {
.name = "lm87",
+ .of_match_table = lm87_of_match,
},
.probe = lm87_probe,
.id_table = lm87_id,
--
2.9.3
next prev parent reply other threads:[~2017-04-13 0:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-13 0:21 [PATCH v2 1/2] hwmon: (lm87) Remove unused I2C devices driver_data Javier Martinez Canillas
2017-04-13 0:21 ` Javier Martinez Canillas [this message]
2017-04-13 13:10 ` [v2,2/2] hwmon: (lm87) Add OF device ID table Guenter Roeck
2017-04-13 13:08 ` [v2,1/2] hwmon: (lm87) Remove unused I2C devices driver_data Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170413002139.5983-2-javier@osg.samsung.com \
--to=javier@osg.samsung.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox