From: Jean Delvare <jdelvare@suse.de>
To: linux-hwmon@vger.kernel.org
Cc: Russell King <linux@armlinux.org.uk>, Guenter Roeck <linux@roeck-us.net>
Subject: [PATCH] hwmon: (it87) Remove useless test during device detection
Date: Thu, 4 May 2017 11:35:06 +0200 [thread overview]
Message-ID: <20170504113506.1665ecd7@endymion> (raw)
There is no reason to treat the IT8705F differently during device
detection. If a single IT8705F chip indeed answers to both Super-IO
addresses, we have code in place to detect the duplicate device
address and skip the second one.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Russell King <linux@armlinux.org.uk>
Cc: Guenter Roeck <linux@roeck-us.net>
---
drivers/hwmon/it87.c | 7 -------
1 file changed, 7 deletions(-)
--- linux-4.11.orig/drivers/hwmon/it87.c 2017-05-01 04:47:48.000000000 +0200
+++ linux-4.11/drivers/hwmon/it87.c 2017-05-04 11:17:49.868328706 +0200
@@ -3224,13 +3224,6 @@ static int __init sm_it87_init(void)
goto exit_dev_unregister;
found = true;
-
- /*
- * IT8705F may respond on both SIO addresses.
- * Stop probing after finding one.
- */
- if (sio_data.type == it87)
- break;
}
if (!found) {
--
Jean Delvare
SUSE L3 Support
next reply other threads:[~2017-05-04 9:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-04 9:35 Jean Delvare [this message]
2017-05-04 11:33 ` [PATCH] hwmon: (it87) Remove useless test during device detection Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170504113506.1665ecd7@endymion \
--to=jdelvare@suse.de \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox