From: Patrick Venture <venture@google.com>
To: venture@google.com, joel@jms.id.au, jdelvare@suse.com,
linux@roeck-us.net
Cc: linux-hwmon@vger.kernel.org, raltherr@google.com,
emilyshaffer@google.com, peterh@google.com
Subject: [PATCH 1/2] hwmon: (aspeed-pwm-tacho) reduce fan_tach period
Date: Tue, 20 Jun 2017 18:12:27 -0700 [thread overview]
Message-ID: <20170621011228.25128-1-venture@google.com> (raw)
Reduce the fan_tach period such that the fan controller uses a shorter
period to measure the rpm.
Testing: This was tested on an ast2400 sitting on a quanta-q71l.
Signed-off-by: Patrick Venture <venture@google.com>
---
drivers/hwmon/aspeed-pwm-tacho.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hwmon/aspeed-pwm-tacho.c b/drivers/hwmon/aspeed-pwm-tacho.c
index 86e2ea8287a7..b2ab5612d8a4 100644
--- a/drivers/hwmon/aspeed-pwm-tacho.c
+++ b/drivers/hwmon/aspeed-pwm-tacho.c
@@ -160,7 +160,7 @@
* 11: reserved.
*/
#define M_TACH_MODE 0x02 /* 10b */
-#define M_TACH_UNIT 0x1000
+#define M_TACH_UNIT 0x00c0
#define INIT_FAN_CTRL 0xFF
struct aspeed_pwm_tacho_data {
--
2.13.1.611.g7e3b11ae1-goog
next reply other threads:[~2017-06-21 1:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-21 1:12 Patrick Venture [this message]
2017-06-21 1:12 ` [PATCH 2/2] hwmon: (aspeed-pwm-tacho) Poll for fan_tach instead of sleep Patrick Venture
2017-06-21 1:32 ` Guenter Roeck
2017-06-21 1:39 ` Guenter Roeck
2017-06-21 1:42 ` Patrick Venture
2017-06-21 1:52 ` Guenter Roeck
-- strict thread matches above, loose matches on Subject: below --
2017-06-21 1:14 [PATCH 1/2] hwmon: (aspeed-pwm-tacho) reduce fan_tach period Patrick Venture
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170621011228.25128-1-venture@google.com \
--to=venture@google.com \
--cc=emilyshaffer@google.com \
--cc=jdelvare@suse.com \
--cc=joel@jms.id.au \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=peterh@google.com \
--cc=raltherr@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox