From: Guenter Roeck <linux@roeck-us.net>
To: Patrick Venture <venture@google.com>
Cc: joel@jms.id.au, linux-hwmon@vger.kernel.org,
emilyshaffer@google.com, peterh@google.com
Subject: Re: [PATCH 1/2 v2] hwmon: (aspeed-pwm-tacho) reduce fan_tach period
Date: Fri, 23 Jun 2017 08:29:23 -0700 [thread overview]
Message-ID: <20170623152923.GA10652@roeck-us.net> (raw)
In-Reply-To: <20170623150525.7014-1-venture@google.com>
On Fri, Jun 23, 2017 at 08:05:25AM -0700, Patrick Venture wrote:
> Reduce the fan_tach period such that the fan controller uses a shorter
> period to measure the rpm.
>
> Testing: Tested on an ast2400 sitting on a quanta-q71l.
>
> Signed-off-by: Patrick Venture <venture@google.com>
Please provide change logs, and keep version numbers consistent
for a series even if one patch doesn't change.
Now I'll have to go back, find the flurry of older versions, and try
to find out what changed and why. This takes time which I don't have.
I'll probably only get to this after the next commit window, sorry.
Guenter
> ---
> drivers/hwmon/aspeed-pwm-tacho.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/aspeed-pwm-tacho.c b/drivers/hwmon/aspeed-pwm-tacho.c
> index 86e2ea8287a7..b2ab5612d8a4 100644
> --- a/drivers/hwmon/aspeed-pwm-tacho.c
> +++ b/drivers/hwmon/aspeed-pwm-tacho.c
> @@ -160,7 +160,7 @@
> * 11: reserved.
> */
> #define M_TACH_MODE 0x02 /* 10b */
> -#define M_TACH_UNIT 0x1000
> +#define M_TACH_UNIT 0x00c0
> #define INIT_FAN_CTRL 0xFF
>
> struct aspeed_pwm_tacho_data {
> --
> 2.13.1.611.g7e3b11ae1-goog
>
next prev parent reply other threads:[~2017-06-23 15:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-23 15:05 [PATCH 1/2 v2] hwmon: (aspeed-pwm-tacho) reduce fan_tach period Patrick Venture
2017-06-23 15:29 ` Guenter Roeck [this message]
2017-06-23 19:33 ` Patrick Venture
2017-06-23 20:47 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170623152923.GA10652@roeck-us.net \
--to=linux@roeck-us.net \
--cc=emilyshaffer@google.com \
--cc=joel@jms.id.au \
--cc=linux-hwmon@vger.kernel.org \
--cc=peterh@google.com \
--cc=venture@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox