Re: [PATCHv3 4/4] hwmon: da9052: add support for TSI channel

Guenter Roeck
2017-06-29T22:45:01Z

On Thu, Jun 29, 2017 at 11:45:21AM -0700, Dmitry Torokhov wrote:
> Hi Sebastian,
>
> On Thu, Jun 29, 2017 at 02:43:46PM +0200, Sebastian Reichel wrote:
> > @@ -238,6 +239,14 @@ static int da9052_ts_probe(struct platform_device *pdev)
> > if (!da9052)
> > return -EINVAL;
> >
> > + /*
> > + * Check if touchscreen pins are used are analogue input instead
> > + * of having a touchscreen connected to them. The analogue input
> > + * functionality will be provided by hwmon driver (if enabled).
> > + */
> > + if (device_property_read_bool(pdev->dev.parent, "dlg,tsi-as-adc"))
> > + return -ENODEV;
> > +
>
> I believe this is not the right way of doing this. da9052-core should
> simply forgo creating da9052-tsi platform device when this property is
> present.
>
Agreed.

Guenter