From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-path: Received: from bh-25.webhostbox.net ([208.91.199.152]:56617 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752491AbdHICCB (ORCPT ); Tue, 8 Aug 2017 22:02:01 -0400 Date: Tue, 8 Aug 2017 19:02:00 -0700 From: Guenter Roeck To: Julia Lawall Cc: Jean Delvare , bhumirks@gmail.com, kernel-janitors@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [9/9, v2] hwmon: (scpi) constify thermal_zone_of_device_ops structures Message-ID: <20170809020200.GA508@roeck-us.net> References: <1502204943-20075-10-git-send-email-Julia.Lawall@lip6.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1502204943-20075-10-git-send-email-Julia.Lawall@lip6.fr> Sender: linux-hwmon-owner@vger.kernel.org List-Id: linux-hwmon@vger.kernel.org On Tue, Aug 08, 2017 at 05:09:03PM +0200, Julia Lawall wrote: > The thermal_zone_of_device_ops structure is only passed as the fourth > argument to devm_thermal_zone_of_sensor_register, which is declared > as const. Thus the thermal_zone_of_device_ops structure itself can > be const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall Applied to hwmon-next. Thanks, Guenter > --- > > v2: New patch > > drivers/hwmon/scpi-hwmon.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > > diff --git a/drivers/hwmon/scpi-hwmon.c b/drivers/hwmon/scpi-hwmon.c > index a586480..7e49da5 100644 > --- a/drivers/hwmon/scpi-hwmon.c > +++ b/drivers/hwmon/scpi-hwmon.c > @@ -120,7 +120,7 @@ static int scpi_read_temp(void *dev, int *temp) > return sprintf(buf, "%s\n", sensor->info.name); > } > > -static struct thermal_zone_of_device_ops scpi_sensor_ops = { > +static const struct thermal_zone_of_device_ops scpi_sensor_ops = { > .get_temp = scpi_read_temp, > }; >