From: Guenter Roeck <linux@roeck-us.net>
To: Florian Eckert <fe@dev.tdt.de>
Cc: Rob Herring <robh@kernel.org>,
mark.rutland@arm.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org,
jdelvare@suse.com, Guenter Roeck <groeck7@gmail.com>
Subject: Re: [PATCH v3 2/2] hwmon: (ltq-cputemp) add devicetree bindings documentation
Date: Wed, 13 Sep 2017 08:12:34 -0700 [thread overview]
Message-ID: <20170913151234.GH27765@roeck-us.net> (raw)
In-Reply-To: <5da3b25f6eec79f103ef880100a403f7@dev.tdt.de>
On Wed, Sep 13, 2017 at 04:42:33PM +0200, Florian Eckert wrote:
> >>>
> >>>>> +
> >>>>> +Requires node properties:
> >>>>> +- compatible value :
> >>>>> + "lantiq,cputemp"
> >>>
> >>>Kind of non-specific. How is this device even accessed without any other
> >>>property?
> >>
> >>It does not need any further properties. If this is set in the device
> >>tree
> >>then the driver is loaded.
> >>After loading the temperature could be read from "/sys/class/hwmon".
> >>Let me know what should i do to get this fixed?
> >>
>
> What about with this is this OK from your side or do I have do to something?
> So I only update "s/temperatur/temperature/" with an follow-up patch based
> the current linux-next tree?
>
Also s/cputemp@0/cputemp/ if I understand Rob's comment correctly.
Question for Rob: The driver checks the SOC version and bails out
if the version is not vr9 v1.2. Should that be expressed in DT ?
Guenter
> Thanks
>
> Florian
>
>
next prev parent reply other threads:[~2017-09-13 15:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-01 6:58 [PATCH v3 1/2] hwmon: (ltq-cputemp) add cpu temp sensor driver Florian Eckert
2017-09-01 6:58 ` [PATCH v3 2/2] hwmon: (ltq-cputemp) add devicetree bindings documentation Florian Eckert
2017-09-01 14:26 ` Guenter Roeck
2017-09-12 16:20 ` Rob Herring
2017-09-13 5:36 ` Florian Eckert
2017-09-13 14:12 ` Guenter Roeck
2017-09-13 14:42 ` Florian Eckert
2017-09-13 15:12 ` Guenter Roeck [this message]
2017-09-13 15:25 ` Rob Herring
2017-09-14 7:06 ` Florian Eckert
2017-09-20 2:53 ` Rob Herring
2017-09-13 14:12 ` Guenter Roeck
2017-09-01 14:24 ` [PATCH v3 1/2] hwmon: (ltq-cputemp) add cpu temp sensor driver Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170913151234.GH27765@roeck-us.net \
--to=linux@roeck-us.net \
--cc=devicetree@vger.kernel.org \
--cc=fe@dev.tdt.de \
--cc=groeck7@gmail.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox