From: Guenter Roeck <linux@roeck-us.net>
To: Patrick Venture <venture@google.com>
Cc: joel@jms.id.au, kunyi@google.com, linux-hwmon@vger.kernel.org
Subject: Re: [PATCH] hwmon: (aspeed-pwm-tacho) increase fan tach period
Date: Mon, 18 Sep 2017 07:44:35 -0700 [thread overview]
Message-ID: <20170918144435.GA11868@roeck-us.net> (raw)
In-Reply-To: <20170911224155.146738-1-venture@google.com>
On Mon, Sep 11, 2017 at 03:41:55PM -0700, Patrick Venture wrote:
> The previous value reduced the time required to determine
> the fan value, however, it's also used as the final timeout
> mechanism. The prevous value would work for any fan speed
> greater than around 3k RPM. This increased value, lets the fan
> speeds return quickly but will wait longer to handle speeds below 3k
> RPM.
>
> Testing: this value was determined through experimentation on the ast2400
> on the Quanta-q71l. This configurations runs 8 fans attached to the
> controller.
>
> Signed-off-by: Patrick Venture <venture@google.com>
With reservations:
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
This is the last time for me to accept a patch changing the value of
M_TACH_UNIT in this driver. Any subsequent change will require a more
comprehensive solution.
Guenter
> ---
> drivers/hwmon/aspeed-pwm-tacho.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/aspeed-pwm-tacho.c b/drivers/hwmon/aspeed-pwm-tacho.c
> index 69b97d45e3cb..f914e5f41048 100644
> --- a/drivers/hwmon/aspeed-pwm-tacho.c
> +++ b/drivers/hwmon/aspeed-pwm-tacho.c
> @@ -161,7 +161,7 @@
> * 11: reserved.
> */
> #define M_TACH_MODE 0x02 /* 10b */
> -#define M_TACH_UNIT 0x00c0
> +#define M_TACH_UNIT 0x0210
> #define INIT_FAN_CTRL 0xFF
>
> /* How long we sleep in us while waiting for an RPM result. */
> --
> 2.14.1.581.gf28d330327-goog
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2017-09-18 14:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-11 22:41 [PATCH] hwmon: (aspeed-pwm-tacho) increase fan tach period Patrick Venture
2017-09-11 23:56 ` Joel Stanley
[not found] ` <CAO=notx_s9wYV2W7MXdXesmF_4icqur8UuTH5=vi2ctOWB8aGw@mail.gmail.com>
2017-09-12 19:21 ` Guenter Roeck
2017-09-18 14:44 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170918144435.GA11868@roeck-us.net \
--to=linux@roeck-us.net \
--cc=joel@jms.id.au \
--cc=kunyi@google.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=venture@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox