From: Guenter Roeck <linux@roeck-us.net>
To: Romain Porte <romain.porte@nokia.com>
Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pmbus: added possibility to change timeout for device update
Date: Thu, 2 Nov 2017 12:21:08 -0700 [thread overview]
Message-ID: <20171102192108.GA6049@roeck-us.net> (raw)
In-Reply-To: <cf1535cf-7a76-6d4d-a23f-72077db821ac@nokia.com>
On Thu, Nov 02, 2017 at 05:17:21PM +0100, Romain Porte wrote:
> On 02/11/2017 14:58, Guenter Roeck wrote:
> >NACK, I'd rather drop the caching entirely, and possibly convert the
> >driver to
> >regmap for caching non-volatile registers.
> I need to familiarize myself with regmap then, it looks like a nice
> abstraction to have.
>
> Do you think I can propose an intermediate patch for removing the cache
> support? (both time-based and data->valid based, so that every read actually
> performs a read, everytime)
>
If you manage to do that, yes. That should limit reads to required reads,
not just drop ->valid and re-read every register for each attribute
access. Essentially, pmbus_update_device() should be completely gone.
That isn't easy to implement, which is why I never got to doing it.
Guenter
prev parent reply other threads:[~2017-11-02 19:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-02 11:31 [PATCH] pmbus: added possibility to change timeout for device update Romain Porte
2017-11-02 13:58 ` Guenter Roeck
2017-11-02 16:17 ` Romain Porte
2017-11-02 19:21 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171102192108.GA6049@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=romain.porte@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox