From: Guenter Roeck <linux@roeck-us.net>
To: ahsan_hussain@mentor.com
Cc: jdelvare@suse.com, linux-hwmon@vger.kernel.org,
linux-kernel@vger.kernel.org, noor_ahsan@mentor.com,
cedric_hombourger@mentor.com
Subject: Re: [PATCH 1/1] hwmon: (ina2xx) initialize mutex before locking
Date: Mon, 16 Apr 2018 11:37:05 -0700 [thread overview]
Message-ID: <20180416183705.GA12401@roeck-us.net> (raw)
In-Reply-To: <1523901203-2981-1-git-send-email-ahsan_hussain@mentor.com>
On Mon, Apr 16, 2018 at 10:53:23PM +0500, ahsan_hussain@mentor.com wrote:
> From: Ahsan Hussain <ahsan_hussain@mentor.com>
>
> Upstream commit 8d008c0c ("hwmon: (ina2xx) Make calibration register
> value fixed"), makes ina2xx_set_shunt() call mutex_lock on an
> un-initialized mutex. Initialize it prior so we don't get a NULL pointer
> dereference error.
>
> Fixes: 8d008c0c ("hwmon: (ina2xx) Make calibration register value fixed")
>
> Signed-off-by: Ahsan Hussain <ahsan_hussain@mentor.com>
Hmm ... the patch still does not apply ... having closer look ....
It appears that you don't use the mainline kernel. Commit 8d008c0c
is not upstream. It is in a stable release. Only which one ... ok,
I see it in linux-4.9.y. The offending commit is also in 4.4.y,
4.14.y, and 4.15.y. The fix needs to be pulled from upstream into
those stable releases. I'll send a request to Greg.
Thanks,
Guenter
next prev parent reply other threads:[~2018-04-16 18:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-16 17:53 [PATCH 1/1] hwmon: (ina2xx) initialize mutex before locking ahsan_hussain
2018-04-16 18:37 ` Guenter Roeck [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-04-16 17:08 Ahsan Hussain
2018-04-16 17:28 ` Guenter Roeck
2018-04-16 17:48 ` Ahsan Hussain
2018-04-16 17:51 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180416183705.GA12401@roeck-us.net \
--to=linux@roeck-us.net \
--cc=ahsan_hussain@mentor.com \
--cc=cedric_hombourger@mentor.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=noor_ahsan@mentor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox