public inbox for linux-hwmon@vger.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: minyard@acm.org
Cc: openipmi-developer@lists.sourceforge.net,
	linux-hwmon@vger.kernel.org, Corey Minyard <cminyard@mvista.com>
Subject: Re: [PATCH] hwmon:ibm: Change ipmi_user_t to struct ipmi_user *
Date: Wed, 18 Apr 2018 09:55:59 -0700	[thread overview]
Message-ID: <20180418165559.GD5210@magnolia> (raw)
In-Reply-To: <1524064430-22093-1-git-send-email-minyard@acm.org>

On Wed, Apr 18, 2018 at 10:13:50AM -0500, minyard@acm.org wrote:
> From: Corey Minyard <cminyard@mvista.com>
> 
> Signed-off-by: Corey Minyard <cminyard@mvista.com>
> Cc: Darrick J. Wong <darrick.wong@oracle.com>

Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

--D

> ---
>  drivers/hwmon/ibmaem.c | 2 +-
>  drivers/hwmon/ibmpex.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> I'm getting rid of this annoying coding style violation, if you
> could get this in, that would be great.
> 
> diff --git a/drivers/hwmon/ibmaem.c b/drivers/hwmon/ibmaem.c
> index 1f64378..9e92673 100644
> --- a/drivers/hwmon/ibmaem.c
> +++ b/drivers/hwmon/ibmaem.c
> @@ -101,7 +101,7 @@ static struct platform_driver aem_driver = {
>  struct aem_ipmi_data {
>  	struct completion	read_complete;
>  	struct ipmi_addr	address;
> -	ipmi_user_t		user;
> +	struct ipmi_user	*user;
>  	int			interface;
>  
>  	struct kernel_ipmi_msg	tx_message;
> diff --git a/drivers/hwmon/ibmpex.c b/drivers/hwmon/ibmpex.c
> index 21b9c72..4f7b12b 100644
> --- a/drivers/hwmon/ibmpex.c
> +++ b/drivers/hwmon/ibmpex.c
> @@ -84,7 +84,7 @@ struct ibmpex_bmc_data {
>  
>  	struct ipmi_addr	address;
>  	struct completion	read_complete;
> -	ipmi_user_t		user;
> +	struct ipmi_user	*user;
>  	int			interface;
>  
>  	struct kernel_ipmi_msg	tx_message;
> -- 
> 2.7.4
> 

      parent reply	other threads:[~2018-04-18 16:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-18 15:13 [PATCH] hwmon:ibm: Change ipmi_user_t to struct ipmi_user * minyard
2018-04-18 16:10 ` Guenter Roeck
2018-04-18 17:18   ` [Openipmi-developer] " Corey Minyard
2018-04-18 16:55 ` Darrick J. Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180418165559.GD5210@magnolia \
    --to=darrick.wong@oracle.com \
    --cc=cminyard@mvista.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=minyard@acm.org \
    --cc=openipmi-developer@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox