* [PATCH] hwmon:ibm: Change ipmi_user_t to struct ipmi_user *
@ 2018-04-18 15:13 minyard
2018-04-18 16:10 ` Guenter Roeck
2018-04-18 16:55 ` Darrick J. Wong
0 siblings, 2 replies; 4+ messages in thread
From: minyard @ 2018-04-18 15:13 UTC (permalink / raw)
To: Darrick J . Wong; +Cc: openipmi-developer, linux-hwmon, Corey Minyard
From: Corey Minyard <cminyard@mvista.com>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
Cc: Darrick J. Wong <darrick.wong@oracle.com>
---
drivers/hwmon/ibmaem.c | 2 +-
drivers/hwmon/ibmpex.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
I'm getting rid of this annoying coding style violation, if you
could get this in, that would be great.
diff --git a/drivers/hwmon/ibmaem.c b/drivers/hwmon/ibmaem.c
index 1f64378..9e92673 100644
--- a/drivers/hwmon/ibmaem.c
+++ b/drivers/hwmon/ibmaem.c
@@ -101,7 +101,7 @@ static struct platform_driver aem_driver = {
struct aem_ipmi_data {
struct completion read_complete;
struct ipmi_addr address;
- ipmi_user_t user;
+ struct ipmi_user *user;
int interface;
struct kernel_ipmi_msg tx_message;
diff --git a/drivers/hwmon/ibmpex.c b/drivers/hwmon/ibmpex.c
index 21b9c72..4f7b12b 100644
--- a/drivers/hwmon/ibmpex.c
+++ b/drivers/hwmon/ibmpex.c
@@ -84,7 +84,7 @@ struct ibmpex_bmc_data {
struct ipmi_addr address;
struct completion read_complete;
- ipmi_user_t user;
+ struct ipmi_user *user;
int interface;
struct kernel_ipmi_msg tx_message;
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] hwmon:ibm: Change ipmi_user_t to struct ipmi_user *
2018-04-18 15:13 [PATCH] hwmon:ibm: Change ipmi_user_t to struct ipmi_user * minyard
@ 2018-04-18 16:10 ` Guenter Roeck
2018-04-18 17:18 ` [Openipmi-developer] " Corey Minyard
2018-04-18 16:55 ` Darrick J. Wong
1 sibling, 1 reply; 4+ messages in thread
From: Guenter Roeck @ 2018-04-18 16:10 UTC (permalink / raw)
To: minyard; +Cc: Darrick J . Wong, openipmi-developer, linux-hwmon, Corey Minyard
On Wed, Apr 18, 2018 at 10:13:50AM -0500, minyard@acm.org wrote:
> From: Corey Minyard <cminyard@mvista.com>
>
> Signed-off-by: Corey Minyard <cminyard@mvista.com>
> Cc: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> drivers/hwmon/ibmaem.c | 2 +-
> drivers/hwmon/ibmpex.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> I'm getting rid of this annoying coding style violation, if you
> could get this in, that would be great.
>
Not for 4.17, if that is what you are asking for. Feel free to push it
as part of a series - for that, you have my
Acked-by: Guenter Roeck <linux@roeck-us.net>
Let me know if you want me to queue it for 4.18.
Guenter
> diff --git a/drivers/hwmon/ibmaem.c b/drivers/hwmon/ibmaem.c
> index 1f64378..9e92673 100644
> --- a/drivers/hwmon/ibmaem.c
> +++ b/drivers/hwmon/ibmaem.c
> @@ -101,7 +101,7 @@ static struct platform_driver aem_driver = {
> struct aem_ipmi_data {
> struct completion read_complete;
> struct ipmi_addr address;
> - ipmi_user_t user;
> + struct ipmi_user *user;
> int interface;
>
> struct kernel_ipmi_msg tx_message;
> diff --git a/drivers/hwmon/ibmpex.c b/drivers/hwmon/ibmpex.c
> index 21b9c72..4f7b12b 100644
> --- a/drivers/hwmon/ibmpex.c
> +++ b/drivers/hwmon/ibmpex.c
> @@ -84,7 +84,7 @@ struct ibmpex_bmc_data {
>
> struct ipmi_addr address;
> struct completion read_complete;
> - ipmi_user_t user;
> + struct ipmi_user *user;
> int interface;
>
> struct kernel_ipmi_msg tx_message;
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Openipmi-developer] [PATCH] hwmon:ibm: Change ipmi_user_t to struct ipmi_user *
2018-04-18 16:10 ` Guenter Roeck
@ 2018-04-18 17:18 ` Corey Minyard
0 siblings, 0 replies; 4+ messages in thread
From: Corey Minyard @ 2018-04-18 17:18 UTC (permalink / raw)
To: Guenter Roeck
Cc: linux-hwmon, Corey Minyard, openipmi-developer, Darrick J . Wong
On 04/18/2018 11:10 AM, Guenter Roeck wrote:
> On Wed, Apr 18, 2018 at 10:13:50AM -0500, minyard@acm.org wrote:
>> From: Corey Minyard <cminyard@mvista.com>
>>
>> Signed-off-by: Corey Minyard <cminyard@mvista.com>
>> Cc: Darrick J. Wong <darrick.wong@oracle.com>
>> ---
>> drivers/hwmon/ibmaem.c | 2 +-
>> drivers/hwmon/ibmpex.c | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> I'm getting rid of this annoying coding style violation, if you
>> could get this in, that would be great.
>>
> Not for 4.17, if that is what you are asking for. Feel free to push it
> as part of a series - for that, you have my
>
> Acked-by: Guenter Roeck <linux@roeck-us.net>
>
> Let me know if you want me to queue it for 4.18.
Thanks. I'll add it to my queue for 4.18.
-corey
> Guenter
>
>> diff --git a/drivers/hwmon/ibmaem.c b/drivers/hwmon/ibmaem.c
>> index 1f64378..9e92673 100644
>> --- a/drivers/hwmon/ibmaem.c
>> +++ b/drivers/hwmon/ibmaem.c
>> @@ -101,7 +101,7 @@ static struct platform_driver aem_driver = {
>> struct aem_ipmi_data {
>> struct completion read_complete;
>> struct ipmi_addr address;
>> - ipmi_user_t user;
>> + struct ipmi_user *user;
>> int interface;
>>
>> struct kernel_ipmi_msg tx_message;
>> diff --git a/drivers/hwmon/ibmpex.c b/drivers/hwmon/ibmpex.c
>> index 21b9c72..4f7b12b 100644
>> --- a/drivers/hwmon/ibmpex.c
>> +++ b/drivers/hwmon/ibmpex.c
>> @@ -84,7 +84,7 @@ struct ibmpex_bmc_data {
>>
>> struct ipmi_addr address;
>> struct completion read_complete;
>> - ipmi_user_t user;
>> + struct ipmi_user *user;
>> int interface;
>>
>> struct kernel_ipmi_msg tx_message;
>> --
>> 2.7.4
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> Openipmi-developer mailing list
> Openipmi-developer@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/openipmi-developer
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] hwmon:ibm: Change ipmi_user_t to struct ipmi_user *
2018-04-18 15:13 [PATCH] hwmon:ibm: Change ipmi_user_t to struct ipmi_user * minyard
2018-04-18 16:10 ` Guenter Roeck
@ 2018-04-18 16:55 ` Darrick J. Wong
1 sibling, 0 replies; 4+ messages in thread
From: Darrick J. Wong @ 2018-04-18 16:55 UTC (permalink / raw)
To: minyard; +Cc: openipmi-developer, linux-hwmon, Corey Minyard
On Wed, Apr 18, 2018 at 10:13:50AM -0500, minyard@acm.org wrote:
> From: Corey Minyard <cminyard@mvista.com>
>
> Signed-off-by: Corey Minyard <cminyard@mvista.com>
> Cc: Darrick J. Wong <darrick.wong@oracle.com>
Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> drivers/hwmon/ibmaem.c | 2 +-
> drivers/hwmon/ibmpex.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> I'm getting rid of this annoying coding style violation, if you
> could get this in, that would be great.
>
> diff --git a/drivers/hwmon/ibmaem.c b/drivers/hwmon/ibmaem.c
> index 1f64378..9e92673 100644
> --- a/drivers/hwmon/ibmaem.c
> +++ b/drivers/hwmon/ibmaem.c
> @@ -101,7 +101,7 @@ static struct platform_driver aem_driver = {
> struct aem_ipmi_data {
> struct completion read_complete;
> struct ipmi_addr address;
> - ipmi_user_t user;
> + struct ipmi_user *user;
> int interface;
>
> struct kernel_ipmi_msg tx_message;
> diff --git a/drivers/hwmon/ibmpex.c b/drivers/hwmon/ibmpex.c
> index 21b9c72..4f7b12b 100644
> --- a/drivers/hwmon/ibmpex.c
> +++ b/drivers/hwmon/ibmpex.c
> @@ -84,7 +84,7 @@ struct ibmpex_bmc_data {
>
> struct ipmi_addr address;
> struct completion read_complete;
> - ipmi_user_t user;
> + struct ipmi_user *user;
> int interface;
>
> struct kernel_ipmi_msg tx_message;
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-04-18 17:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-18 15:13 [PATCH] hwmon:ibm: Change ipmi_user_t to struct ipmi_user * minyard
2018-04-18 16:10 ` Guenter Roeck
2018-04-18 17:18 ` [Openipmi-developer] " Corey Minyard
2018-04-18 16:55 ` Darrick J. Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox