From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-path: Received: from bh-25.webhostbox.net ([208.91.199.152]:45499 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932446AbeF2RMW (ORCPT ); Fri, 29 Jun 2018 13:12:22 -0400 Date: Fri, 29 Jun 2018 10:12:20 -0700 From: Guenter Roeck To: Andrew Lunn Cc: netdev , Florian Fainelli , Russell King , vadimp@mellanox.com, linux-hwmon@vger.kernel.org Subject: Re: [PATCH RFC 1/2] hwmon: Add support for power min, lcrit, min_alarm and lcrit_alarm Message-ID: <20180629171220.GA7470@roeck-us.net> References: <1530218475-4369-1-git-send-email-andrew@lunn.ch> <1530218475-4369-2-git-send-email-andrew@lunn.ch> <20180628224236.GB20118@roeck-us.net> <20180629072156.GA11285@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180629072156.GA11285@lunn.ch> Sender: linux-hwmon-owner@vger.kernel.org List-Id: linux-hwmon@vger.kernel.org On Fri, Jun 29, 2018 at 09:21:56AM +0200, Andrew Lunn wrote: > On Thu, Jun 28, 2018 at 03:42:36PM -0700, Guenter Roeck wrote: > > On Thu, Jun 28, 2018 at 10:41:14PM +0200, Andrew Lunn wrote: > > > Some sensors support reporting minimal and lower critical power, as > > > well as alarms when these thresholds are reached. Add support for > > > these attributes to the hwmon core. > > > > > > Signed-off-by: Andrew Lunn > > > > I am inclined to accept this patch immediately. I'll do that > > in the next couple of days unless someone gives me a good reason > > not to. > > Hi Guenter > > We need to watch out for merge dependencies. If you take it, you > probably should also take the second patch into your tree as > well. Otherwise, you need a stable branch DaveM can pull into net-next > if he takes the second patch. > Good point. I don't have anything queued for hwmon.c, so it should be ok for the patch to go through networking. I'll Ack it when the time comes. > I also have a patch to lm-sensors sensors, so it prints these > values. I will create a github pull request. > Excellent. Thanks, Guenter