From: Guenter Roeck <linux@roeck-us.net>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Jean Delvare <jdelvare@suse.com>,
Tokunori Ikegami <ikegami@allied-telesis.co.jp>,
linux-hwmon@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/2] hwmon: (adt7475) Potential error pointer dereferences
Date: Tue, 14 Aug 2018 06:39:34 -0700 [thread overview]
Message-ID: <20180814133934.GA11077@roeck-us.net> (raw)
In-Reply-To: <20180814091236.zubxfj32bedobr52@kili.mountain>
On Tue, Aug 14, 2018 at 12:12:36PM +0300, Dan Carpenter wrote:
> The adt7475_update_device() function returns error pointers. The
> problem is that in show_pwmfreq() we dereference it before the check.
> And then in pwm_use_point2_pwm_at_crit_show() there isn't a check at
> all. I don't know if it's required, but it silences a static checker
> warning and it's doesn't hurt anything to check.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Reviewed-by: Tokunori Ikegami <ikegami@allied-telesis.co.jp>
Applied.
Thanks,
Guenter
prev parent reply other threads:[~2018-08-14 16:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-14 9:12 [PATCH 1/2] hwmon: (adt7475) Potential error pointer dereferences Dan Carpenter
2018-08-14 9:14 ` [PATCH 2/2] hwmon: (adt7475) Remove some unnecessary checks Dan Carpenter
2018-08-14 9:34 ` IKEGAMI Tokunori
2018-08-14 9:57 ` Dan Carpenter
2018-08-14 10:07 ` [PATCH 2/2 v2] hwmon: (adt7475) Make adt7475_read_word() return errors Dan Carpenter
2018-08-14 10:12 ` IKEGAMI Tokunori
2018-08-14 13:40 ` Guenter Roeck
2018-08-15 6:02 ` IKEGAMI Tokunori
2018-08-15 12:37 ` Guenter Roeck
2018-08-21 2:40 ` IKEGAMI Tokunori
2018-08-14 9:32 ` [PATCH 1/2] hwmon: (adt7475) Potential error pointer dereferences IKEGAMI Tokunori
2018-08-14 13:39 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180814133934.GA11077@roeck-us.net \
--to=linux@roeck-us.net \
--cc=dan.carpenter@oracle.com \
--cc=ikegami@allied-telesis.co.jp \
--cc=jdelvare@suse.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox