From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-path: Received: from mail-pl1-f194.google.com ([209.85.214.194]:43021 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725881AbeKSJD0 (ORCPT ); Mon, 19 Nov 2018 04:03:26 -0500 Received: by mail-pl1-f194.google.com with SMTP id g59-v6so13608023plb.10 for ; Sun, 18 Nov 2018 14:41:51 -0800 (PST) Date: Sun, 18 Nov 2018 14:41:48 -0800 From: Guenter Roeck To: Huacai Chen Cc: Jean Delvare , linux-hwmon@vger.kernel.org, Fuxin Zhang , Yao Wang Subject: Re: [PATCH] hwmon: (w83795) temp4_type has writable permission Message-ID: <20181118224148.GA381@roeck-us.net> References: <1542249898-20406-1-git-send-email-chenhc@lemote.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1542249898-20406-1-git-send-email-chenhc@lemote.com> Sender: linux-hwmon-owner@vger.kernel.org List-Id: linux-hwmon@vger.kernel.org On Thu, Nov 15, 2018 at 10:44:57AM +0800, Huacai Chen wrote: > Signed-off-by: Yao Wang > Signed-off-by: Huacai Chen Applied, after adding separately sent description / rationale. For future submission I would kindly suggest to send patches with complete descriptions. Thanks, Guenter > --- > drivers/hwmon/w83795.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hwmon/w83795.c b/drivers/hwmon/w83795.c > index 49276bb..1bb80f9 100644 > --- a/drivers/hwmon/w83795.c > +++ b/drivers/hwmon/w83795.c > @@ -1691,7 +1691,7 @@ store_sf_setup(struct device *dev, struct device_attribute *attr, > * somewhere else in the code > */ > #define SENSOR_ATTR_TEMP(index) { \ > - SENSOR_ATTR_2(temp##index##_type, S_IRUGO | (index < 4 ? S_IWUSR : 0), \ > + SENSOR_ATTR_2(temp##index##_type, S_IRUGO | (index < 5 ? S_IWUSR : 0), \ > show_temp_mode, store_temp_mode, NOT_USED, index - 1), \ > SENSOR_ATTR_2(temp##index##_input, S_IRUGO, show_temp, \ > NULL, TEMP_READ, index - 1), \