From: Guenter Roeck <linux@roeck-us.net>
To: Vadim Pasternak <vadimp@mellanox.com>
Cc: linux-hwmon@vger.kernel.org, michaelsh@mellanox.com
Subject: Re: [PATCH hwmon-next v1 1/1] hwmon: (mlxreg-fan) Modify macros for tachometer fault status reading
Date: Wed, 21 Nov 2018 15:44:34 -0800 [thread overview]
Message-ID: <20181121234434.GA5142@roeck-us.net> (raw)
In-Reply-To: <1542755796-70329-1-git-send-email-vadimp@mellanox.com>
On Tue, Nov 20, 2018 at 11:16:36PM +0000, Vadim Pasternak wrote:
> Modify macros for tachometer fault status reading for making it more
> simple and clear.
>
> Signed-off-by: Vadim Pasternak <vadimp@mellanox.com>
Applied to hwmon-next.
Thanks,
Guenter
> ---
> drivers/hwmon/mlxreg-fan.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/mlxreg-fan.c b/drivers/hwmon/mlxreg-fan.c
> index d8fa4be..db8c6de 100644
> --- a/drivers/hwmon/mlxreg-fan.c
> +++ b/drivers/hwmon/mlxreg-fan.c
> @@ -51,7 +51,7 @@
> */
> #define MLXREG_FAN_GET_RPM(rval, d, s) (DIV_ROUND_CLOSEST(15000000 * 100, \
> ((rval) + (s)) * (d)))
> -#define MLXREG_FAN_GET_FAULT(val, mask) (!((val) ^ (mask)))
> +#define MLXREG_FAN_GET_FAULT(val, mask) ((val) == (mask))
> #define MLXREG_FAN_PWM_DUTY2STATE(duty) (DIV_ROUND_CLOSEST((duty) * \
> MLXREG_FAN_MAX_STATE, \
> MLXREG_FAN_MAX_DUTY))
prev parent reply other threads:[~2018-11-22 10:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-20 23:16 [PATCH hwmon-next v1 1/1] hwmon: (mlxreg-fan) Modify macros for tachometer fault status reading Vadim Pasternak
2018-11-21 23:44 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181121234434.GA5142@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-hwmon@vger.kernel.org \
--cc=michaelsh@mellanox.com \
--cc=vadimp@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox