From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-path: Received: from mail-pl1-f193.google.com ([209.85.214.193]:46416 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726228AbeLLOpN (ORCPT ); Wed, 12 Dec 2018 09:45:13 -0500 Date: Wed, 12 Dec 2018 06:45:09 -0800 From: Guenter Roeck To: YueHaibing Cc: Luca Tettamanti , Jean Delvare , linux-hwmon@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH -next] hwmon: Fix debugfs_simple_attr.cocci warnings Message-ID: <20181212144509.GA7173@roeck-us.net> References: <1544603796-173016-1-git-send-email-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1544603796-173016-1-git-send-email-yuehaibing@huawei.com> Sender: linux-hwmon-owner@vger.kernel.org List-Id: linux-hwmon@vger.kernel.org On Wed, Dec 12, 2018 at 08:36:36AM +0000, YueHaibing wrote: > Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE > for debugfs files. > > Semantic patch information: > Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file() > imposes some significant overhead as compared to > DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe(). > > Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci > > Signed-off-by: YueHaibing Applied. In future patches, please refer to the affected driver in the subject line. Thanks, Guenter > --- > drivers/hwmon/asus_atk0110.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/drivers/hwmon/asus_atk0110.c b/drivers/hwmon/asus_atk0110.c > index a5638d1..22be78c 100644 > --- a/drivers/hwmon/asus_atk0110.c > +++ b/drivers/hwmon/asus_atk0110.c > @@ -681,10 +681,8 @@ static int atk_debugfs_gitm_get(void *p, u64 *val) > return err; > } > > -DEFINE_SIMPLE_ATTRIBUTE(atk_debugfs_gitm, > - atk_debugfs_gitm_get, > - NULL, > - "0x%08llx\n"); > +DEFINE_DEBUGFS_ATTRIBUTE(atk_debugfs_gitm, atk_debugfs_gitm_get, NULL, > + "0x%08llx\n"); > > static int atk_acpi_print(char *buf, size_t sz, union acpi_object *obj) > { > @@ -803,8 +801,8 @@ static void atk_debugfs_init(struct atk_data *data) > if (!f || IS_ERR(f)) > goto cleanup; > > - f = debugfs_create_file("gitm", 0400, d, data, > - &atk_debugfs_gitm); > + f = debugfs_create_file_unsafe("gitm", 0400, d, data, > + &atk_debugfs_gitm); > if (!f || IS_ERR(f)) > goto cleanup; >