From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f67.google.com ([209.85.221.67]:36798 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731314AbeLUOr7 (ORCPT ); Fri, 21 Dec 2018 09:47:59 -0500 Received: by mail-wr1-f67.google.com with SMTP id u4so5524772wrp.3 for ; Fri, 21 Dec 2018 06:47:57 -0800 (PST) Date: Fri, 21 Dec 2018 14:47:54 +0000 From: Lee Jones To: Jae Hyun Yoo Cc: Rob Herring , Jean Delvare , Guenter Roeck , Mark Rutland , Joel Stanley , Andrew Jeffery , Jonathan Corbet , Greg Kroah-Hartman , Gustavo Pimentel , Kishon Vijay Abraham I , Lorenzo Pieralisi , "Darrick J . Wong" , Eric Sandeen , Arnd Bergmann , Wu Hao , Tomohiro Kusumi , "Bryant G . Ly" , Frederic Barrat , "David S . Miller" , Mauro Carvalho Chehab , Andrew Morton , Randy Dunlap , Philippe Ombredanne , Vinod Koul , Stephen Boyd , David Kershner , Uwe Kleine-Konig , Sagar Dharia , Johan Hovold , Thomas Gleixner , Juergen Gross , Cyrille Pitchen , linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, openbmc@lists.ozlabs.org, James Feist , Jason M Biils , Vernon Mauery Subject: Re: [PATCH v9 07/12] dt-bindings: mfd: Add a document for PECI client MFD Message-ID: <20181221144754.GS13248@dell> References: <20181218210417.30140-1-jae.hyun.yoo@linux.intel.com> <20181218210417.30140-8-jae.hyun.yoo@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20181218210417.30140-8-jae.hyun.yoo@linux.intel.com> Sender: linux-hwmon-owner@vger.kernel.org List-Id: linux-hwmon@vger.kernel.org On Tue, 18 Dec 2018, Jae Hyun Yoo wrote: > This commit adds a dt-bindings document for PECI client MFD. > > Cc: Lee Jones > Cc: Rob Herring > Cc: Mark Rutland > Cc: Andrew Jeffery > Cc: James Feist > Cc: Jason M Biils > Cc: Joel Stanley > Cc: Vernon Mauery > Signed-off-by: Jae Hyun Yoo > Reviewed-by: Rob Herring > --- > .../bindings/mfd/intel-peci-client.txt | 34 +++++++++++++++++++ > 1 file changed, 34 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/intel-peci-client.txt > > diff --git a/Documentation/devicetree/bindings/mfd/intel-peci-client.txt b/Documentation/devicetree/bindings/mfd/intel-peci-client.txt > new file mode 100644 > index 000000000000..5d1d5d0a552f > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/intel-peci-client.txt > @@ -0,0 +1,34 @@ > +* Intel PECI client bindings > + > +PECI (Platform Environment Control Interface) is a one-wire bus interface that > +provides a communication channel from PECI clients in Intel processors and > +chipset components to external monitoring or control devices. PECI is designed > +to support the following sideband functions: > + > +- Processor and DRAM thermal management > +- Platform Manageability > +- Processor Interface Tuning and Diagnostics > +- Failure Analysis > + > +Required properties: > +- compatible : Should be "intel,peci-client". > +- reg : Should contain address of a client CPU. According to the PECI > + specification, client addresses start from 0x30. > + > +Example: > + peci-bus@0 { > + compatible = "vendor,soc-peci"; > + reg = <0x0 0x1000>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + peci-client@30 { > + compatible = "intel,peci-client"; > + reg = <0x30>; > + }; > + > + peci-client@31 { > + compatible = "intel,peci-client"; > + reg = <0x31>; > + }; The PECI Client driver (masquerading as an MFD driver in this set) doesn't actually do anything special. Instead of detailing it here, register the child devices directly instead. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog