linux-hwmon.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Jean-Francois Dagenais <jeff.dagenais@gmail.com>
Cc: linux-hwmon@vger.kernel.org, jdelvare@suse.com
Subject: Re: [PATCH v4] hwmon: max6650: add thermal cooling device capability
Date: Fri, 19 Apr 2019 06:40:10 -0700	[thread overview]
Message-ID: <20190419134010.GA18697@roeck-us.net> (raw)
In-Reply-To: <20190419131520.GA2566@roeck-us.net>

On Fri, Apr 19, 2019 at 06:15:20AM -0700, Guenter Roeck wrote:
> On Thu, Apr 18, 2019 at 08:57:22PM -0400, Jean-Francois Dagenais wrote:
> > This allows max6650 devices to be referenced in dts as a cooling device.
> > 
> > The pwm value seems duplicated in cooling_dev_state but since pwm goes
> > through rounding logic into data->dac, it is modified and messes with
> > the thermal zone state algorithms. It's also better to serve a cache
> > value, thus avoiding periodic actual i2c traffic.
> > 
> > Signed-off-by: Jean-Francois Dagenais <jeff.dagenais@gmail.com>
> 
> Looking into this more closely, I notice that it has a substantial downside:
> It only registers one channel with the thermal subsystem. That is ok for
> max6650, but it is a problem for max6651. There, it only registers a single
> channel. Worse, extending it later would be difficult since the single-channel
> support implies that the thermal data in the dts file would (probably) have to
> look completely different for multi-channel support.
> 
> How does your proposed dts file look like ? Can we possibly adjust it to work
> with multiple channels (ie with all channels of max6651) ?
> 
Never mind, I am talking nonsense. The max6651 has 4 tachometer input channels,
but only one pwm channel. Sorry for the noise. I'll apply your patch.

Can you send me a register dump for the chip (from i2cdump) ? 

Thanks,
Guenter

  reply	other threads:[~2019-04-19 19:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-19 13:15 [PATCH v4] hwmon: max6650: add thermal cooling device capability Guenter Roeck
2019-04-19 13:40 ` Guenter Roeck [this message]
2019-04-20  2:44   ` Jean-Francois Dagenais
  -- strict thread matches above, loose matches on Subject: below --
2019-04-18 22:02 [PATCH v2] " Guenter Roeck
2019-04-19  0:57 ` [PATCH v4] " Jean-Francois Dagenais

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190419134010.GA18697@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=jdelvare@suse.com \
    --cc=jeff.dagenais@gmail.com \
    --cc=linux-hwmon@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).