* Removing ADS1015 driver from hwmon subsystem
@ 2019-06-08 1:13 Guenter Roeck
2019-06-08 10:01 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Guenter Roeck @ 2019-06-08 1:13 UTC (permalink / raw)
To: Jonathan Cameron, Dirk Eibach
Cc: linux-hwmon@vger.kernel.org, linux-iio@vger.kernel.org
Hi all,
there are currently two drivers for ADS1015 in the linux kernel:
drivers/iio/adc/ti-ads1015.c
drivers/hwmon/ads1015.c
The driver in the iio subsystem provides more flexible support for
the chip's capabilities. Even if the hwmon driver is removed,
the iio->hwmon bridge can still be used and would provide the same
information as before to the user. Existing devicetree entries
for ads1015 both point to the iio driver. The platform include file
is only included by the drivers, but not from any platform code.
With that in mind, keeping the hwmon driver around does not really
add value. I suggest to remove it. Are there any objections or
concerns ?
Thanks,
Guenter
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Removing ADS1015 driver from hwmon subsystem
2019-06-08 1:13 Removing ADS1015 driver from hwmon subsystem Guenter Roeck
@ 2019-06-08 10:01 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2019-06-08 10:01 UTC (permalink / raw)
To: Guenter Roeck
Cc: Dirk Eibach, linux-hwmon@vger.kernel.org,
linux-iio@vger.kernel.org
On Fri, 7 Jun 2019 18:13:27 -0700
Guenter Roeck <linux@roeck-us.net> wrote:
> Hi all,
>
> there are currently two drivers for ADS1015 in the linux kernel:
>
> drivers/iio/adc/ti-ads1015.c
> drivers/hwmon/ads1015.c
>
> The driver in the iio subsystem provides more flexible support for
> the chip's capabilities. Even if the hwmon driver is removed,
> the iio->hwmon bridge can still be used and would provide the same
> information as before to the user. Existing devicetree entries
> for ads1015 both point to the iio driver. The platform include file
> is only included by the drivers, but not from any platform code.
>
> With that in mind, keeping the hwmon driver around does not really
> add value. I suggest to remove it. Are there any objections or
> concerns ?
It is probably not worth the dance of creating a stub driver
in hwmon to bring up the iio->hwmon bridge but that might be
an option if anyone minds just dropping the ads1015 hwmon driver.
Thanks,
Jonathan
>
> Thanks,
> Guenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-08 10:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-08 1:13 Removing ADS1015 driver from hwmon subsystem Guenter Roeck
2019-06-08 10:01 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).