Re: [PATCH v2 1/4] i2c/busses: Add i2c-icy for I2C on m68k/Amiga

Max Staudt
2019-08-15T12:11:02Z

On 08/15/2019 02:04 PM, Wolfram Sang wrote:
>> When the PCF8584 is addressed as slave, this register
>> must be loaded with the 7-bit I 2 C-bus address to which the
>> PCF8584 is to respond. During initialization, the own
>> address register S0' must be written to, regardless
>> whether it is later used.
>
> I see. It must be written a non-zero value to leave the monitor mode.
> But this really needs no callback, we can hardcode any non-zero value.
> If slave support is (ever) to be implemented, the own address will come
> from the I2C core.
The callback, just like getclock(), is from the existing i2c-algo-pcf, which I don't want to touch right now. So I'm afraid it has to stay, even if it returns a fixed number.

Touching or forking i2c-algo-pcf will be necessary in order to implement IRQ support, if I ever get around to it. I've wasted too much time on debugging IRQ support, and would rather do it another time, if ever ;)
I've left a comment block at the start of i2c-icy.c for anyone interested in the gory details.

If this is okay with you, I'll send another round of patches. :)

Thanks!

Max