Re: [PATCH v2] hwmon: Driver for temperature sensors on SATA drives

Martin K. Petersen
2020-01-07T04:10:52Z

Hi Guenter!

>> - I still think sensor naming needs work. How and where are the
>> "drivetemp-scsi-8-140" names generated?
>>
> Quick one: In libsensors, outside the kernel. The naming is generic,
> along the line of <driver name>-<bus name>-<bus index>-<slot>.

I understand that there are sensors that may not have an obvious
associated topology and therefore necessitate coming up with a suitable
naming or enumeration scheme. But in this case we already have a
well-defined SCSI device name. Any particular reason you don't shift the
chip.addr back and print the H:C:T:L format that you used as input?

However arcane H:C:T:L may seem, I think that predictable naming would
make things a lot easier for users that need to identify which device
matches which sensor...

--
Martin K. Petersen Oracle Linux Engineering