Re: [PATCH] hwmon: (dell-smm) Add Latitude 5480 to fan control whitelist

[Jeffrey Lin <jeffrey@icurse.nl>]

[-- Attachment #1: Type: text/plain, Size: 1479 bytes --]

On Fri, 19 Jun 2020 14:18:21 +0200
Pali Rohár <pali@kernel.org> wrote:

>On Thursday 18 June 2020 21:55:29 Jeffrey Lin wrote:
>> This allows manual PWM control without the BIOS fighting back on Dell
>> Latitude 5480.
>> 
>> Signed-off-by: Jeffrey Lin <jeffrey@icurse.nl>  
>
>If it is working fine on your machine, you can add my:

Yes, the below patch works on my machine.  dmesg reports "dell_smm_hwmon:
enabling support for setting automatic/manual fan control" and writing 1 to
/sys/class/hwmon/hwmon4/pwm1_enable allows pwmconfig/fancontrol full control.

>
>Acked-by: Pali Rohár <pali@kernel.org>
>
>> ---
>>  drivers/hwmon/dell-smm-hwmon.c | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>> 
>> diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
>> index 16be012a95ed..ec448f5f2dc3 100644
>> --- a/drivers/hwmon/dell-smm-hwmon.c
>> +++ b/drivers/hwmon/dell-smm-hwmon.c
>> @@ -1187,6 +1187,14 @@ static struct dmi_system_id
>> i8k_whitelist_fan_control[] __initdata = { },
>>  		.driver_data = (void
>> *)&i8k_fan_control_data[I8K_FAN_34A3_35A3], },
>> +	{
>> +		.ident = "Dell Latitude 5480",
>> +		.matches = {
>> +			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
>> +			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Latitude 5480"),
>> +		},
>> +		.driver_data = (void
>> *)&i8k_fan_control_data[I8K_FAN_34A3_35A3],
>> +	},
>>  	{
>>  		.ident = "Dell Latitude E6440",
>>  		.matches = {
>> -- 
>> 2.27.0
>>   


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 981 bytes --]