Re: [PATCH] dt-bindings: hwmon: Correct vendor for mcp980x

Guenter Roeck
2020-07-03T21:59:16Z

On 7/3/20 8:37 AM, Daniel M. Weeks wrote:
> Signed-off-by: Daniel M. Weeks <dan@danweeks.net>
> ---
> Documentation/devicetree/bindings/hwmon/lm75.txt | 2 +-
> drivers/hwmon/lm75.c | 8 ++++----
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/hwmon/lm75.txt b/Documentation/devicetree/bindings/hwmon/lm75.txt
> index 273616702c51..e5bb554cd2c3 100644
> --- a/Documentation/devicetree/bindings/hwmon/lm75.txt
> +++ b/Documentation/devicetree/bindings/hwmon/lm75.txt
> @@ -14,10 +14,10 @@ Required properties:
> "maxim,max6626",
> "maxim,max31725",
> "maxim,max31726",
> - "maxim,mcp980x",
> "nxp,pct2075",
> "st,stds75",
> "st,stlm75",
> + "microchip,mcp980x",
> "microchip,tcn75",
> "ti,tmp100",
> "ti,tmp101",
> diff --git a/drivers/hwmon/lm75.c b/drivers/hwmon/lm75.c
> index ba0be48aeadd..a8cfc7e4a685 100644
> --- a/drivers/hwmon/lm75.c
> +++ b/drivers/hwmon/lm75.c
> @@ -690,10 +690,6 @@ static const struct of_device_id __maybe_unused lm75_of_match[] = {
> .compatible = "maxim,max31726",
> .data = (void *)max31725
> },
> - {
> - .compatible = "maxim,mcp980x",
> - .data = (void *)mcp980x
> - },
> {
> .compatible = "nxp,pct2075",
> .data = (void *)pct2075
> @@ -706,6 +702,10 @@ static const struct of_device_id __maybe_unused lm75_of_match[] = {
> .compatible = "st,stlm75",
> .data = (void *)stlm75
> },
> + {
> + .compatible = "microchip,mcp980x",
> + .data = (void *)mcp980x

Hmm, makes me wonder if we should replace this with correct chip names
since we are at it. After all, it only includes mcp980{0,1,2,3} and not mcp9805.

Rob, any thoughts ?

Guenter

> + },
> {
> .compatible = "microchip,tcn75",
> .data = (void *)tcn75
>