Re: [PATCH 1/4] dt-bindings: Add missing 'unevaluatedProperties'

Geert Uytterhoeven
2020-10-06T07:37:59Z

Hi Rob,

On Mon, Oct 5, 2020 at 8:39 PM Rob Herring <robh@kernel.org> wrote:
> This doesn't yet do anything in the tools, but make it explicit so we can
> check either 'unevaluatedProperties' or 'additionalProperties' is present
> in schemas.
>
> 'unevaluatedProperties' is appropriate when including another schema (via
> '$ref') and all possible properties and/or child nodes are not
> explicitly listed in the schema with the '$ref'.
>
> This is in preparation to add a meta-schema to check for missing
> 'unevaluatedProperties' or 'additionalProperties'. This has been a
> constant source of review issues.
>
> Signed-off-by: Rob Herring <robh@kernel.org>

Thanks for your patch!

> Documentation/devicetree/bindings/bus/renesas,bsc.yaml | 2 ++
> .../bindings/memory-controllers/renesas,rpc-if.yaml | 2 ++
> Documentation/devicetree/bindings/net/renesas,ether.yaml | 2 ++
> Documentation/devicetree/bindings/serial/renesas,hscif.yaml | 2 ++
> Documentation/devicetree/bindings/serial/renesas,sci.yaml | 2 ++
> Documentation/devicetree/bindings/serial/renesas,scif.yaml | 2 ++
> Documentation/devicetree/bindings/serial/renesas,scifa.yaml | 2 ++
> Documentation/devicetree/bindings/serial/renesas,scifb.yaml | 2 ++
> Documentation/devicetree/bindings/spi/renesas,hspi.yaml | 2 ++
> Documentation/devicetree/bindings/spi/renesas,rspi.yaml | 2 ++
> Documentation/devicetree/bindings/spi/renesas,sh-msiof.yaml | 2 ++

Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>

> --- a/Documentation/devicetree/bindings/net/renesas,ether.yaml
> +++ b/Documentation/devicetree/bindings/net/renesas,ether.yaml
> @@ -85,6 +85,8 @@ required:
> - clocks
> - pinctrl-0
>
> +unevaluatedProperties: false

This one has received an "additionalProperties: false" in commit
41506bff84f1563e ("dt-bindings: net: renesas, ether: Improve schema validation")
in net-next, which you probably want to remove.

> +
> examples:
> # Lager board
> - |

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds