From: Paul Barker <pbarker@konsulko.com>
To: Kamil Debski <kamil@wypas.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>
Cc: Paul Barker <pbarker@konsulko.com>, linux-hwmon@vger.kernel.org
Subject: [PATCH v2 0/2] pwm-fan: Refactor and convert to recommended API
Date: Sat, 28 Nov 2020 17:49:07 +0000 [thread overview]
Message-ID: <20201128174909.26687-1-pbarker@konsulko.com> (raw)
This series includes the first patch from my previous series adding support
for multiple fan tachometers [1] which Guenter has already reviewed, plus a
second patch to convert the driver to use the hwmon_device_register_with_info
API as requested.
These patches have been tested on a SanCloud BeagleBone Enhanced using an
oscilloscope to check the PWM output and a signal generator to simulate
the fan tachometer signals. I've tested both with and without a fan
tachometer input defined in the device tree.
There shouldn't be any functional change to the driver after these patches,
it just puts us in a much better place for further development.
These changes can also be pulled from:
https://gitlab.com/pbarker.dev/staging/linux.git
tag: for-hwmon/pwm-fan-refactor-v2_2020-11-28
Changes from v1:
* Addressed review comment from Guenter: Simplify pwm_fan_write, return
-ENOTSUPP from pwm_fan_read if the wrong type is given, use devm_kcalloc
instead of devm_kzalloc to ensure multiplication is safe.
Paul Barker (2):
hwmon: pwm-fan: Refactor pwm_fan_probe
hwmon: pwm-fan: Convert to hwmon_device_register_with_info API
drivers/hwmon/pwm-fan.c | 164 +++++++++++++++++++++++++---------------
1 file changed, 104 insertions(+), 60 deletions(-)
base-commit: e6e2c18f63c62df778ce484945fccad088594533
--
2.26.2
next reply other threads:[~2020-11-28 22:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-28 17:49 Paul Barker [this message]
2020-11-28 17:49 ` [PATCH v2 1/2] hwmon: pwm-fan: Refactor pwm_fan_probe Paul Barker
2020-11-28 20:20 ` Guenter Roeck
2020-11-28 17:49 ` [PATCH v2 2/2] hwmon: pwm-fan: Convert to hwmon_device_register_with_info API Paul Barker
2020-11-28 20:20 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201128174909.26687-1-pbarker@konsulko.com \
--to=pbarker@konsulko.com \
--cc=b.zolnierkie@samsung.com \
--cc=jdelvare@suse.com \
--cc=kamil@wypas.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox