public inbox for linux-hwmon@vger.kernel.org
 help / color / mirror / Atom feed
From: Paul Barker <pbarker@konsulko.com>
To: Kamil Debski <kamil@wypas.org>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Jean Delvare <jdelvare@suse.com>,
	Guenter Roeck <linux@roeck-us.net>
Cc: Paul Barker <pbarker@konsulko.com>, linux-hwmon@vger.kernel.org
Subject: [PATCH v3 0/2] pwm-fan: Support multiple tachometer inputs
Date: Sat, 12 Dec 2020 19:50:06 +0000	[thread overview]
Message-ID: <20201212195008.6036-1-pbarker@konsulko.com> (raw)

These changes were made to support a custom board where one PWM output
is routed to two fans, each of which has a tachometer signal routed to a
GPIO input on the SoC.

As the custom board doesn't currently support the latest mainline kernel
I've tested these changes on a SanCloud BeagleBone Enhanced using an
oscilloscope to check the PWM output and a signal generator to simulate
the fan tachometer signals. I've tested variants of the device tree with
0, 1 and 2 fan tachometer inputs configured to ensure the logic in the
probe function is correct.

The device tree bindings changes have been submitted in a separate
series:
https://lore.kernel.org/linux-devicetree/20200920180943.352526-1-pbarker@konsulko.com/

These changes can also be pulled from:

  https://gitlab.com/pbarker.dev/staging/linux.git
  tag: for-hwmon/pwm-fan-tachometers-v3_2020-12-12

Changes since v2:

  * Split refactoring and API conversion into a separate patch series
    which has now been accepted. These changes now use the recommended
    hwmon API and dynamically allocate struct hwmon_channel_info
    objects as needed.

  * Rebased changes on the current HEAD of hwmon-next.

Changes since v1:

  * Split RPM calculation fix into a separate patch which has now been
    accepted.

  * Break the changes down into smaller patches so they're easier to
    review.

  * Rebased changes on hwmon-next.

Paul Barker (2):
  hwmon: pwm-fan: Store tach data separately
  hwmon: pwm-fan: Support multiple fan tachometers

 drivers/hwmon/pwm-fan.c | 111 +++++++++++++++++++++++++---------------
 1 file changed, 69 insertions(+), 42 deletions(-)


base-commit: 1a033769a4fe9a86ee791fd553b6a996dd76e026
-- 
2.26.2


             reply	other threads:[~2020-12-12 19:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-12 19:50 Paul Barker [this message]
2020-12-12 19:50 ` [PATCH v3 1/2] hwmon: pwm-fan: Store tach data separately Paul Barker
2020-12-30 16:18   ` Guenter Roeck
2020-12-12 19:50 ` [PATCH v3 2/2] hwmon: pwm-fan: Support multiple fan tachometers Paul Barker
2020-12-30 16:18   ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201212195008.6036-1-pbarker@konsulko.com \
    --to=pbarker@konsulko.com \
    --cc=b.zolnierkie@samsung.com \
    --cc=jdelvare@suse.com \
    --cc=kamil@wypas.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux@roeck-us.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox