Re: [PATCH] hwmon: SENSORS_SBTSI should depend on X86

Kun Yi
2020-12-16T17:28:37Z

On Wed, Dec 16, 2020 at 8:31 AM Guenter Roeck <linux@roeck-us.net> wrote:
>
> On Wed, Dec 16, 2020 at 02:46:41PM +0100, Geert Uytterhoeven wrote:
> > The AMD SB Temperature Sensor Interface (SB-TSI) is only present on AMD
> > X86 SoCs. Hence add a dependency on X86, to prevent asking the user
> > about this driver when configuring a kernel without AMD X86 platform
> > support.

Sorry, I think there is some confusion. AMD SoC is a 'remote sensor',
or the client, whereas the device using the SB-TSI hwmon driver is the
master.
In industry, a typical scenario is ARM-based Board Management
Controllers (BMCs) using SB-TSI to monitor the host CPU temperature.

> >
> > Fixes: e7bb1a2ab8c4b156 ("hwmon: (sbtsi) Add basic support for SB-TSI sensors")
> > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
>
> Makes sense. Applied.
>
> Thanks,
> Guenter
>
> > ---
> > drivers/hwmon/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
> > index 1ecf697d8d99b70c..63d28f98108d4bb5 100644
> > --- a/drivers/hwmon/Kconfig
> > +++ b/drivers/hwmon/Kconfig
> > @@ -1536,6 +1536,7 @@ config SENSORS_SL28CPLD
> > config SENSORS_SBTSI
> > tristate "Emulated SB-TSI temperature sensor"
> > depends on I2C
> > + depends on X86 || COMPILE_TEST
> > help
> > If you say yes here you get support for emulated temperature
> > sensors on AMD SoCs with SB-TSI interface connected to a BMC device.
> > --
> > 2.25.1
> >

--
Regards,
Kun