From: Guenter Roeck <linux@roeck-us.net>
To: David Arcari <darcari@redhat.com>
Cc: linux-hwmon@vger.kernel.org,
Naveen Krishna Chatradhi <nchatrad@amd.com>,
Jean Delvare <jdelvare@suse.com>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] hwmon: (amd_energy) fix allocation of hwmon_channel_info config
Date: Fri, 8 Jan 2021 07:32:37 -0800 [thread overview]
Message-ID: <20210108153237.GA182053@roeck-us.net> (raw)
In-Reply-To: <20210107144707.6927-1-darcari@redhat.com>
On Thu, Jan 07, 2021 at 09:47:07AM -0500, David Arcari wrote:
> hwmon, specifically hwmon_num_channel_attrs, expects the config
> array in the hwmon_channel_info structure to be terminated by
> a zero entry. amd_energy does not honor this convention. As
> result, a KASAN warning is possible. Fix this by adding an
> additional entry and setting it to zero.
>
> Fixes: 8abee9566b7e ("hwmon: Add amd_energy driver to report energy counters")
>
> Signed-off-by: David Arcari <darcari@redhat.com>
> Cc: Naveen Krishna Chatradhi <nchatrad@amd.com>
> Cc: Jean Delvare <jdelvare@suse.com>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: linux-kernel@vger.kernel.org
> Cc: stable@vger.kernel.org
> Signed-off-by: David Arcari <darcari@redhat.com>
> Acked-by: Naveen Krishna Chatradhi <nchatrad@amd.com>
Applied.
Thanks,
Guenter
prev parent reply other threads:[~2021-01-08 15:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-07 14:47 [PATCH] hwmon: (amd_energy) fix allocation of hwmon_channel_info config David Arcari
2021-01-08 5:49 ` Chatradhi, Naveen Krishna
2021-01-08 6:17 ` Guenter Roeck
2021-01-08 6:19 ` Chatradhi, Naveen Krishna
2021-01-08 15:32 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210108153237.GA182053@roeck-us.net \
--to=linux@roeck-us.net \
--cc=darcari@redhat.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nchatrad@amd.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox