From: Guenter Roeck <linux@roeck-us.net>
To: YANG LI <abaci-bugfix@linux.alibaba.com>
Cc: jdelvare@suse.com, linux-hwmon@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: abx500: style: Simplify bool comparison
Date: Thu, 21 Jan 2021 11:29:42 -0800 [thread overview]
Message-ID: <20210121192942.GA31224@roeck-us.net> (raw)
In-Reply-To: <1610358729-86795-1-git-send-email-abaci-bugfix@linux.alibaba.com>
On Mon, Jan 11, 2021 at 05:52:09PM +0800, YANG LI wrote:
> Fix the following coccicheck warning:
> ./drivers/hwmon/abx500.c:84:8-26: WARNING: Comparison to bool
>
> Signed-off-by: YANG LI <abaci-bugfix@linux.alibaba.com>
> Reported-by: Abaci Robot<abaci@linux.alibaba.com>
This driver will be removed in v5.11.
Guenter
> ---
> drivers/hwmon/abx500.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/abx500.c b/drivers/hwmon/abx500.c
> index 4b96488..3879b13 100644
> --- a/drivers/hwmon/abx500.c
> +++ b/drivers/hwmon/abx500.c
> @@ -81,7 +81,7 @@ static void gpadc_monitor(struct work_struct *work)
>
> if (data->min[i] != 0) {
> if (temp < data->min[i]) {
> - if (data->min_alarm[i] == false) {
> + if (!data->min_alarm[i]) {
> data->min_alarm[i] = true;
> updated_min_alarm = true;
> }
prev parent reply other threads:[~2021-01-21 19:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-11 9:52 [PATCH] hwmon: abx500: style: Simplify bool comparison YANG LI
2021-01-21 19:29 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210121192942.GA31224@roeck-us.net \
--to=linux@roeck-us.net \
--cc=abaci-bugfix@linux.alibaba.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox