From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D200C433DB for ; Wed, 27 Jan 2021 16:48:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 38FB860187 for ; Wed, 27 Jan 2021 16:48:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231281AbhA0Qs0 (ORCPT ); Wed, 27 Jan 2021 11:48:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46168 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232348AbhA0Qr7 (ORCPT ); Wed, 27 Jan 2021 11:47:59 -0500 Received: from mail-ot1-x333.google.com (mail-ot1-x333.google.com [IPv6:2607:f8b0:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7BDF4C061573; Wed, 27 Jan 2021 08:47:19 -0800 (PST) Received: by mail-ot1-x333.google.com with SMTP id i30so2296509ota.6; Wed, 27 Jan 2021 08:47:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=t6uTcRB+VXkCIz3lATiC5ggdGg++l8XBk0JLBAVQyRQ=; b=fCW6mx9zEt2P86ZIqjIsfJcDC1V4MfMEZyirQNvF2vL1kz3lJUWtTGd8TUDd7hakp8 k32c6iRH8RPNgnYa75OBVDpqZANTvlys+z1EG4hKaTCWruNFx/tAZ7fC8uDoDZ8B5IYx xkGSeP9dyiTpCI8lE8s/T0/alGi180d7s3omYCcS0G0kUcEhce1MJl/Q5qq/H2pnsful CjP4xDV7KlVd1sdtqZof84gg6Q0oFB0NKe5m4XlLZfUqmgJnwQSYgoYoh06kruXjZDl+ UUqIVADrPqcbNYW0UdEn4gkf7KY4ruQ3LDUGnqck3ixESYsaXbjawfI73+tLXVPI1iz9 iH2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=t6uTcRB+VXkCIz3lATiC5ggdGg++l8XBk0JLBAVQyRQ=; b=uibVIV2Mg3OLNQnGUlrcniBYGde5Qsb+k/9c5E58bk63ng2tUUoKcOsggNjijKu09q +HzZcY7cRd8S9PaSQtTby0f+Em5V7VYa0hNFzbpqDfMM7ANhrN1WJgsTwenSTnItvXnB F15LgimZPPzQ+Dzmagi6Z974TWef1wYUGgjgyJ3BeY0Z46UTvh9eOjzWfU1R32HmUhh2 ixglDrwCeZ1mfgf8YQ7iI/jZBHU3SieFBujVyazCIqJfMxtIRSScDwTrrEKTNCbA5pcm mXusqZs2x2RbRwsnRHcXXhGSFH52a98vvkqcWOFr2WuzHvOkfjBvvCe48rA8213eNsjQ JBvw== X-Gm-Message-State: AOAM532wLrSMduV9k+Sy0sS+sZH7+J8k8OvF3zh7F/ysiVs6T9AsoMCx gxbLUoiVP8k78+GM7Uj01hY= X-Google-Smtp-Source: ABdhPJzKG5KnvSNuCkZXm21/QqAzF/JQysiApHzQFt10KML1H/pgvR8MPsys8PnMbxu5Dcc53D7EsA== X-Received: by 2002:a9d:748a:: with SMTP id t10mr8321054otk.336.1611766038922; Wed, 27 Jan 2021 08:47:18 -0800 (PST) Received: from localhost ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id k20sm447650otr.34.2021.01.27.08.47.17 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 27 Jan 2021 08:47:18 -0800 (PST) Sender: Guenter Roeck Date: Wed, 27 Jan 2021 08:47:16 -0800 From: Guenter Roeck To: Dan Carpenter Cc: Jean Delvare , Johannes Cornelis Draaijer , linux-hwmon@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] hwmon: (aht10) Unlock on error in aht10_read_values() Message-ID: <20210127164716.GA144600@roeck-us.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org On Wed, Jan 27, 2021 at 08:25:26AM +0300, Dan Carpenter wrote: > This error path needs to drop the lock before returning. > > Fixes: afd018716398 ("hwmon: Add AHT10 Temperature and Humidity Sensor Driver") > Signed-off-by: Dan Carpenter Applied. Thanks, Guenter