From: Guenter Roeck <linux@roeck-us.net>
To: Yang Li <yang.lee@linux.alibaba.com>
Cc: jdelvare@suse.com, linux-hwmon@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: Switch to using the new API kobj_to_dev()
Date: Thu, 11 Mar 2021 13:38:31 -0800 [thread overview]
Message-ID: <20210311213831.GA35420@roeck-us.net> (raw)
In-Reply-To: <1614071667-5665-1-git-send-email-yang.lee@linux.alibaba.com>
On Tue, Feb 23, 2021 at 05:14:27PM +0800, Yang Li wrote:
> fixed the following coccicheck:
> ./drivers/hwmon/hwmon.c:82:60-61: WARNING opportunity for kobj_to_dev()
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Applied.
Thanks,
Guenter
> ---
> drivers/hwmon/hwmon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/hwmon.c b/drivers/hwmon/hwmon.c
> index 6c68405..fd47ab4 100644
> --- a/drivers/hwmon/hwmon.c
> +++ b/drivers/hwmon/hwmon.c
> @@ -79,7 +79,7 @@ struct hwmon_thermal_data {
> static umode_t hwmon_dev_name_is_visible(struct kobject *kobj,
> struct attribute *attr, int n)
> {
> - struct device *dev = container_of(kobj, struct device, kobj);
> + struct device *dev = kobj_to_dev(kobj);
>
> if (to_hwmon_device(dev)->name == NULL)
> return 0;
prev parent reply other threads:[~2021-03-11 21:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-23 9:14 [PATCH] hwmon: Switch to using the new API kobj_to_dev() Yang Li
2021-03-11 21:38 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210311213831.GA35420@roeck-us.net \
--to=linux@roeck-us.net \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox