From: Guenter Roeck <linux@roeck-us.net>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: rafael@kernel.org, andriy.shevchenko@linux.intel.com,
linux-kernel@vger.kernel.org, Jean Delvare <jdelvare@suse.com>,
"open list:HARDWARE MONITORING" <linux-hwmon@vger.kernel.org>
Subject: Re: [PATCH v2 5/9] hwmon/drivers/mr75203: Use HZ macros
Date: Thu, 11 Mar 2021 13:44:05 -0800 [thread overview]
Message-ID: <20210311214405.GA35866@roeck-us.net> (raw)
In-Reply-To: <20210224144222.23762-5-daniel.lezcano@linaro.org>
On Wed, Feb 24, 2021 at 03:42:15PM +0100, Daniel Lezcano wrote:
> HZ unit conversion macros are available in units.h, use them and
> remove the duplicate definition.
I assume the idea is to submit the series together, so
Acked-by: Guenter Roeck <linux@roeck-us.net>
Guenter
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> Reviewed-by: Christian Eggers <ceggers@arri.de>
> ---
> drivers/hwmon/mr75203.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/mr75203.c b/drivers/hwmon/mr75203.c
> index 18da5a25e89a..868243dba1ee 100644
> --- a/drivers/hwmon/mr75203.c
> +++ b/drivers/hwmon/mr75203.c
> @@ -17,6 +17,7 @@
> #include <linux/property.h>
> #include <linux/regmap.h>
> #include <linux/reset.h>
> +#include <linux/units.h>
>
> /* PVT Common register */
> #define PVT_IP_CONFIG 0x04
> @@ -37,7 +38,6 @@
> #define CLK_SYNTH_EN BIT(24)
> #define CLK_SYS_CYCLES_MAX 514
> #define CLK_SYS_CYCLES_MIN 2
> -#define HZ_PER_MHZ 1000000L
>
> #define SDIF_DISABLE 0x04
>
prev parent reply other threads:[~2021-03-11 21:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210224144222.23762-1-daniel.lezcano@linaro.org>
2021-02-24 14:42 ` [PATCH v2 5/9] hwmon/drivers/mr75203: Use HZ macros Daniel Lezcano
2021-03-11 21:44 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210311214405.GA35866@roeck-us.net \
--to=linux@roeck-us.net \
--cc=andriy.shevchenko@linux.intel.com \
--cc=daniel.lezcano@linaro.org \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox