Re: [PATCH V2] hwmon: (ina2xx) Convert sysfs sprintf/snprintf family to sysfs_emit

[Guenter Roeck <linux@roeck-us.net>]

On Tue, Mar 16, 2021 at 07:00:57PM +0800, Jay Fang wrote:
> From: Zihao Tang <tangzihao1@hisilicon.com>
> 
> Fix the following coccicheck warning:
> 
> drivers/hwmon/ina2xx.c:313:8-16: WARNING: use scnprintf or sprintf
> drivers/hwmon/ina2xx.c:453:8-16: WARNING: use scnprintf or sprintf
> drivers/hwmon/ina2xx.c:484:8-16: WARNING: use scnprintf or sprintf
> drivers/hwmon/ina2xx.c:540:8-16: WARNING: use scnprintf or sprintf
> 
> Signed-off-by: Zihao Tang <tangzihao1@hisilicon.com>
> Signed-off-by: Jay Fang <f.fangjian@huawei.com>

Applied.

Thanks,
Guenter

> ---
>  drivers/hwmon/ina2xx.c | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/hwmon/ina2xx.c b/drivers/hwmon/ina2xx.c
> index ca97f9e..8acb2db 100644
> --- a/drivers/hwmon/ina2xx.c
> +++ b/drivers/hwmon/ina2xx.c
> @@ -310,8 +310,7 @@ static ssize_t ina2xx_value_show(struct device *dev,
>  	if (err < 0)
>  		return err;
>  
> -	return snprintf(buf, PAGE_SIZE, "%d\n",
> -			ina2xx_get_value(data, attr->index, regval));
> +	return sysfs_emit(buf, "%d\n", ina2xx_get_value(data, attr->index, regval));
>  }
>  
>  static int ina226_reg_to_alert(struct ina2xx_data *data, u8 bit, u16 regval)
> @@ -450,7 +449,7 @@ static ssize_t ina226_alarm_show(struct device *dev,
>  
>  	alarm = (regval & BIT(attr->index)) &&
>  		(regval & INA226_ALERT_FUNCTION_FLAG);
> -	return snprintf(buf, PAGE_SIZE, "%d\n", alarm);
> +	return sysfs_emit(buf, "%d\n", alarm);
>  }
>  
>  /*
> @@ -481,7 +480,7 @@ static ssize_t ina2xx_shunt_show(struct device *dev,
>  {
>  	struct ina2xx_data *data = dev_get_drvdata(dev);
>  
> -	return snprintf(buf, PAGE_SIZE, "%li\n", data->rshunt);
> +	return sysfs_emit(buf, "%li\n", data->rshunt);
>  }
>  
>  static ssize_t ina2xx_shunt_store(struct device *dev,
> @@ -537,7 +536,7 @@ static ssize_t ina226_interval_show(struct device *dev,
>  	if (status)
>  		return status;
>  
> -	return snprintf(buf, PAGE_SIZE, "%d\n", ina226_reg_to_interval(regval));
> +	return sysfs_emit(buf, "%d\n", ina226_reg_to_interval(regval));
>  }
>  
>  /* shunt voltage */