Re: [hwmon:hwmon-next 33/33] drivers/hwmon/pmbus/fsp-3y.c:204:48: warning: missing braces around initializer

[Guenter Roeck <linux@roeck-us.net>]

On Thu, Apr 15, 2021 at 06:34:41PM +0200, Václav Kubernát wrote:
> Hello.
> 
> I received this email only after I submitted the PSU patch. I'm not
> sure what I should do. Also, I don't understand the warning, I don't
> know where the braces are missing.
> 

It wanted { } to terminate the list instead of { 0 }. Or, of course,
{NULL, 0}, but that would just add unnecessary compexity.

I fixed it up, no need to resend.

Guenter

> Václav
> 
> st 14. 4. 2021 v 17:11 odesílatel kernel test robot <lkp@intel.com> napsal:
> >
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next
> > head:   f0af35c3a1254fc0cca601cdc4f228b9ad24a2a4
> > commit: f0af35c3a1254fc0cca601cdc4f228b9ad24a2a4 [33/33] hwmon: Add driver for fsp-3y PSUs and PDUs
> > config: arc-allyesconfig (attached as .config)
> > compiler: arceb-elf-gcc (GCC) 9.3.0
> > reproduce (this is a W=1 build):
> >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> >         chmod +x ~/bin/make.cross
> >         # https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git/commit/?id=f0af35c3a1254fc0cca601cdc4f228b9ad24a2a4
> >         git remote add hwmon https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git
> >         git fetch --no-tags hwmon hwmon-next
> >         git checkout f0af35c3a1254fc0cca601cdc4f228b9ad24a2a4
> >         # save the attached .config to linux build tree
> >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross W=1 ARCH=arc
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@intel.com>
> >
> > All warnings (new ones prefixed by >>):
> >
> > >> drivers/hwmon/pmbus/fsp-3y.c:204:48: warning: missing braces around initializer [-Wmissing-braces]
> >      204 | static const struct i2c_device_id fsp3y_id[] = {
> >          |                                                ^
> >    ......
> >      207 |  {0}
> >          |   {}
> >
> >
> > vim +204 drivers/hwmon/pmbus/fsp-3y.c
> >
> >    203
> >  > 204  static const struct i2c_device_id fsp3y_id[] = {
> >    205          {"ym2151e", ym2151e},
> >    206          {"yh5151e", yh5151e},
> >    207          {0}
> >    208  };
> >    209
> >
> > ---
> > 0-DAY CI Kernel Test Service, Intel Corporation
> > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org