From: Guenter Roeck <linux@roeck-us.net>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Andrej Picej <andpicej@gmail.com>,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
Jean Delvare <jdelvare@suse.com>
Subject: Re: [PATCH v1 1/1] hwmon: (lm70) Use SPI_MODE_X_MASK
Date: Mon, 10 May 2021 08:01:39 -0700 [thread overview]
Message-ID: <20210510150139.GA1960244@roeck-us.net> (raw)
In-Reply-To: <20210510141331.56736-1-andriy.shevchenko@linux.intel.com>
On Mon, May 10, 2021 at 05:13:31PM +0300, Andy Shevchenko wrote:
> Use SPI_MODE_X_MASK instead of open coded variant.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Applied to hwmon-next.
Thanks,
Guenter
> ---
> drivers/hwmon/lm70.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/lm70.c b/drivers/hwmon/lm70.c
> index 40eab3349904..cdf23a59a203 100644
> --- a/drivers/hwmon/lm70.c
> +++ b/drivers/hwmon/lm70.c
> @@ -184,7 +184,7 @@ static int lm70_probe(struct spi_device *spi)
>
>
> /* signaling is SPI_MODE_0 */
> - if (spi->mode & (SPI_CPOL | SPI_CPHA))
> + if ((spi->mode & SPI_MODE_X_MASK) != SPI_MODE_0)
> return -EINVAL;
>
> /* NOTE: we assume 8-bit words, and convert to 16 bits manually */
prev parent reply other threads:[~2021-05-10 15:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-10 14:13 [PATCH v1 1/1] hwmon: (lm70) Use SPI_MODE_X_MASK Andy Shevchenko
2021-05-10 15:01 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210510150139.GA1960244@roeck-us.net \
--to=linux@roeck-us.net \
--cc=andpicej@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox