Re: [PATCH 1/7] hwmon: (max31790) Fix fan speed reporting for fan7..12

Jan Kundrát
2021-06-02T12:27:04Z

On středa 26. května 2021 17:40:16 CEST, Guenter Roeck wrote:
> Fans 7..12 do not have their own set of configuration registers.
> So far the code ignored that and read beyond the end of the configuration
> register range to get the tachometer period. This resulted in more or less
> random fan speed values for those fans.
>
> The datasheet is quite vague when it comes to defining the tachometer
> period for fans 7..12. Experiments confirm that the period is the same
> for both fans associated with a given set of configuration registers.
>
> Fixes: 54187ff9d766 ("hwmon: (max31790) Convert to use new
> hwmon registration API")
> Fixes: 195a4b4298a7 ("hwmon: Driver for Maxim MAX31790")
> Cc: Jan Kundrát <jan.kundrat@cesnet.cz>
> Cc: Václav Kubernát <kubernat@cesnet.cz>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>

Reviewed-by: Jan Kundrát <jan.kundrat@cesnet.cz>

Cheers,
Jan