From: Guenter Roeck <linux@roeck-us.net>
To: Robert Marko <robert.marko@sartura.hr>
Cc: jdelvare@suse.com, linux-hwmon@vger.kernel.org,
linux-kernel@vger.kernel.org, luka.perkov@sartura.hr
Subject: Re: [PATCH 3/3] hwmon: (tps23861) correct shunt LSB values
Date: Thu, 10 Jun 2021 08:40:28 -0700 [thread overview]
Message-ID: <20210610154028.GA3859122@roeck-us.net> (raw)
In-Reply-To: <20210609220728.499879-3-robert.marko@sartura.hr>
On Thu, Jun 10, 2021 at 12:07:28AM +0200, Robert Marko wrote:
> Current shunt LSB values got reversed during in the
> original driver commit.
>
> So, correct the current shunt LSB values according to
> the datasheet.
>
> This caused reading slightly skewed current values.
>
> Fixes: fff7b8ab2255 ("hwmon: add Texas Instruments TPS23861 driver")
> Signed-off-by: Robert Marko <robert.marko@sartura.hr>
Applied.
Thanks,
Guenter
next prev parent reply other threads:[~2021-06-10 15:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-09 22:07 [PATCH 1/3] hwmon: (tps23861) define regmap max register Robert Marko
2021-06-09 22:07 ` [PATCH 2/3] hwmon: (tps23861) set current shunt value Robert Marko
2021-06-10 15:39 ` Guenter Roeck
2021-06-09 22:07 ` [PATCH 3/3] hwmon: (tps23861) correct shunt LSB values Robert Marko
2021-06-10 15:40 ` Guenter Roeck [this message]
2021-06-10 15:36 ` [PATCH 1/3] hwmon: (tps23861) define regmap max register Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210610154028.GA3859122@roeck-us.net \
--to=linux@roeck-us.net \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luka.perkov@sartura.hr \
--cc=robert.marko@sartura.hr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox