public inbox for linux-hwmon@vger.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linux-hwmon@vger.kernel.org, linux-iio@vger.kernel.org,
	Jean Delvare <jdelvare@suse.com>,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH] hwmon: (ntc_thermistor) Drop unused headers.
Date: Sat, 12 Jun 2021 05:26:49 -0700	[thread overview]
Message-ID: <20210612122649.GA318728@roeck-us.net> (raw)
In-Reply-To: <20210611142257.103094-1-jic23@kernel.org>

On Fri, Jun 11, 2021 at 03:22:57PM +0100, Jonathan Cameron wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> 
> The IIO usage in this driver is purely consumer so it should only
> be including linux/iio/consumer.h  Whilst here drop pm_runtime.h
> as there is no runtime power management in the driver.
> 
> Found using include-what-you-use and manual inspection of the
> suggestions.
> 
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Guenter Roeck <linux@roeck-us.net>

Applied.

Thanks,
Guenter

> ---
>  drivers/hwmon/ntc_thermistor.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/hwmon/ntc_thermistor.c b/drivers/hwmon/ntc_thermistor.c
> index 8587189c7f15..18fd6f12ca16 100644
> --- a/drivers/hwmon/ntc_thermistor.c
> +++ b/drivers/hwmon/ntc_thermistor.c
> @@ -8,7 +8,6 @@
>  
>  #include <linux/slab.h>
>  #include <linux/module.h>
> -#include <linux/pm_runtime.h>
>  #include <linux/math64.h>
>  #include <linux/platform_device.h>
>  #include <linux/err.h>
> @@ -17,9 +16,6 @@
>  
>  #include <linux/platform_data/ntc_thermistor.h>
>  
> -#include <linux/iio/iio.h>
> -#include <linux/iio/machine.h>
> -#include <linux/iio/driver.h>
>  #include <linux/iio/consumer.h>
>  
>  #include <linux/hwmon.h>

      reply	other threads:[~2021-06-12 12:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-11 14:22 [PATCH] hwmon: (ntc_thermistor) Drop unused headers Jonathan Cameron
2021-06-12 12:26 ` Guenter Roeck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210612122649.GA318728@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=jdelvare@suse.com \
    --cc=jic23@kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox