public inbox for linux-hwmon@vger.kernel.org
 help / color / mirror / Atom feed
From: "Pali Rohár" <pali@kernel.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Armin Wolf <W_Armin@gmx.de>,
	jdelvare@suse.com, linux-hwmon@vger.kernel.org
Subject: Re: [PATCH v7 0/6] hwmon: (dell-smm-hwmon) Convert to new hwmon registration api
Date: Thu, 29 Jul 2021 09:24:09 +0200	[thread overview]
Message-ID: <20210729072409.vr6ieb4yitbyeijf@pali> (raw)
In-Reply-To: <f63299d4-34e0-87ab-5f27-970d81281a9b@roeck-us.net>

On Wednesday 28 July 2021 19:26:49 Guenter Roeck wrote:
> On 7/28/21 3:49 PM, Armin Wolf wrote:
> > Am 29.07.21 um 00:43 schrieb Guenter Roeck:
> > > On 7/28/21 3:15 PM, W_Armin@gmx.de wrote:
> > > > From: Armin Wolf <W_Armin@gmx.de>
> > > > 
> > > > This patch series is converting the dell-smm-hwmon driver
> > > > to the new hwmon registration API. In order to do so,
> > > > it introduces a platform device in the first patch, and
> > > > applies some optimisations in the next three patches.
> > > > The switch to the new hwmon registration API is done in
> > > > the next patch. The last patch is fixing a small bug.
> > > > 
> > > > The caching of the fan/temp values was modified to better fit
> > > > the new hwmon API.
> > > > 
> > > > The patches work fine for my Dell Latitude C600, but i whould
> > > > appreciate someone testing the code on another model too.
> > > > 
> > > 
> > > At this point I'd suggest to queue the series up in -next and see
> > > what happens. I don't think we'll get additional feedback.
> > > 
> > > Thought ? Objections ?
> > > 
> > > Guenter
> > > 
> > I agree, its unlikely that the code still has big issues, it works on
> > the C600.
> > The only thing still untested is reading fan rpm/changing fan control, but
> > i expect them to work.
> 
> Let's see if Pali has any objections. If not, I'll apply the series tomorrow.
> 
> Guenter
> 

Fine for me! Also I want to try to find some time to these patches on
more Dell laptops...

      reply	other threads:[~2021-07-29  7:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-28 22:15 [PATCH v7 0/6] hwmon: (dell-smm-hwmon) Convert to new hwmon registration api W_Armin
2021-07-28 22:15 ` [PATCH v7 1/6] hwmon: (dell-smm-hwmon) Use platform device W_Armin
2021-07-28 22:15 ` [PATCH v7 2/6] hwmon: (dell-smm-hwmon) Mark functions as __init W_Armin
2021-07-28 22:15 ` [PATCH v7 3/6] hwmon: (dell-smm-hwmon) Use devm_add_action_or_reset() W_Armin
2021-07-28 22:15 ` [PATCH v7 4/6] hwmon: (dell-smm-hwmon) Move variables into a driver private data structure W_Armin
2021-07-28 22:15 ` [PATCH v7 5/6] hwmon: (dell-smm-hwmon) Convert to devm_hwmon_device_register_with_info() W_Armin
2021-07-28 22:15 ` [PATCH v7 6/6] hwmon: (dell-smm-hwmon) Fix fan mutliplier detection for 3rd fan W_Armin
2021-07-28 22:43 ` [PATCH v7 0/6] hwmon: (dell-smm-hwmon) Convert to new hwmon registration api Guenter Roeck
2021-07-28 22:49   ` Armin Wolf
2021-07-29  2:26     ` Guenter Roeck
2021-07-29  7:24       ` Pali Rohár [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210729072409.vr6ieb4yitbyeijf@pali \
    --to=pali@kernel.org \
    --cc=W_Armin@gmx.de \
    --cc=jdelvare@suse.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux@roeck-us.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox