From: Guenter Roeck <linux@roeck-us.net>
To: Vadim Pasternak <vadimp@nvidia.com>
Cc: linux-hwmon@vger.kernel.org
Subject: Re: [PATCH hwmon-next v2 1/3] hwmon: (mlxreg-fan) Extend the maximum number of tachometers
Date: Thu, 16 Sep 2021 13:18:46 -0700 [thread overview]
Message-ID: <20210916201846.GB1966690@roeck-us.net> (raw)
In-Reply-To: <20210916194719.871413-2-vadimp@nvidia.com>
On Thu, Sep 16, 2021 at 10:47:17PM +0300, Vadim Pasternak wrote:
> Extend support of maximum tachometers from 12 to 14 in order to support
> new systems, equipped with more fans.
>
> Signed-off-by: Vadim Pasternak <vadimp@nvidia.com>
Applied, no need to resend.
> ---
> drivers/hwmon/mlxreg-fan.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/mlxreg-fan.c b/drivers/hwmon/mlxreg-fan.c
> index 89fe7b9fe26b..0f5b109817a7 100644
> --- a/drivers/hwmon/mlxreg-fan.c
> +++ b/drivers/hwmon/mlxreg-fan.c
> @@ -12,7 +12,7 @@
> #include <linux/regmap.h>
> #include <linux/thermal.h>
>
> -#define MLXREG_FAN_MAX_TACHO 12
> +#define MLXREG_FAN_MAX_TACHO 14
> #define MLXREG_FAN_MAX_STATE 10
> #define MLXREG_FAN_MIN_DUTY 51 /* 20% */
> #define MLXREG_FAN_MAX_DUTY 255 /* 100% */
> @@ -266,6 +266,8 @@ static const struct hwmon_channel_info *mlxreg_fan_hwmon_info[] = {
> HWMON_F_INPUT | HWMON_F_FAULT,
> HWMON_F_INPUT | HWMON_F_FAULT,
> HWMON_F_INPUT | HWMON_F_FAULT,
> + HWMON_F_INPUT | HWMON_F_FAULT,
> + HWMON_F_INPUT | HWMON_F_FAULT,
> HWMON_F_INPUT | HWMON_F_FAULT),
> HWMON_CHANNEL_INFO(pwm,
> HWMON_PWM_INPUT),
> --
> 2.20.1
>
next prev parent reply other threads:[~2021-09-16 20:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-16 19:47 [PATCH hwmon-next v2 0/3] hwmon: (mlxreg-fan) Add support for multiply PWM and extend number of tachometers Vadim Pasternak
2021-09-16 19:47 ` [PATCH hwmon-next v2 1/3] hwmon: (mlxreg-fan) Extend the maximum " Vadim Pasternak
2021-09-16 20:18 ` Guenter Roeck [this message]
2021-09-16 19:47 ` [PATCH hwmon-next v2 2/3] hwmon: (mlxreg-fan) Extend driver to support multiply PWM Vadim Pasternak
2021-09-16 20:19 ` Guenter Roeck
2021-09-16 19:47 ` [PATCH hwmon-next v2 3/3] hwmon: (mlxreg-fan) Extend driver to support multiply cooling devices Vadim Pasternak
2021-09-16 20:17 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210916201846.GB1966690@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-hwmon@vger.kernel.org \
--cc=vadimp@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox