From: Guenter Roeck <linux@roeck-us.net>
To: Arnd Bergmann <arnd@kernel.org>
Cc: "Pali Rohár" <pali@kernel.org>,
"Jean Delvare" <jdelvare@suse.com>, "Armin Wolf" <W_Armin@gmx.de>,
"Arnd Bergmann" <arnd@arndb.de>,
"Carlos Alberto Lopez Perez" <clopez@igalia.com>,
"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
"Sebastian Oechsle" <setboolean@icloud.com>,
linux-hwmon@vger.kernel.org,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] hwmon: dell-smm-hwmon: remove unused variable warning
Date: Mon, 20 Sep 2021 07:19:19 -0700 [thread overview]
Message-ID: <20210920141919.GA1639673@roeck-us.net> (raw)
In-Reply-To: <CAK8P3a10NR5CqoTxtjyrx5g6kO-hEkhaw7psEJHSSOZM9S+JXQ@mail.gmail.com>
On Mon, Sep 20, 2021 at 03:14:40PM +0200, Arnd Bergmann wrote:
> On Mon, Sep 20, 2021 at 2:31 PM Pali Rohár <pali@kernel.org> wrote:
> > On Monday 20 September 2021 14:14:16 Arnd Bergmann wrote:
> > > From: Arnd Bergmann <arnd@arndb.de>
> > >
> > > When procfs is disabled
> >
> > ... then the i8k_init_procfs function should not be called as the
> > purpose of I8K code / config option is to export functionality over
> > procfs. So when procfs is disabled then this i8k is noop.
> >
> > Patch which do not allow compilation of I8K when procfs is not enabled
> > is pending here:
> >
> > https://lore.kernel.org/linux-hwmon/20210910071921.16777-1-rdunlap@infradead.org/
> >
> > Ideally please test or review it. As you are not the first one who
> > spotted -Werror problems with i8k and tried to workaround it.
>
> Ok, I'm now using that version in my randconfig tree, it looks sensible
> and it addresses another problem. I'll let you know if something else
> comes up with that patch applied, but I'm sure it fixes the issue
> I reported. Feel free to add
>
> Reported-by: Arnd Bergmann <arnd@arndb.de>
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>
>
> to Randy's patch if you like.
>
You'd have to reply to the patch. This is in x86 world and I can not apply
it, or at least not without Ack from an x86 maintainer. They went ballistic
on me once for doing that, and I won't do it again.
Guenter
next prev parent reply other threads:[~2021-09-20 14:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 12:14 [PATCH] hwmon: dell-smm-hwmon: remove unused variable warning Arnd Bergmann
2021-09-20 12:31 ` Pali Rohár
2021-09-20 13:14 ` Arnd Bergmann
2021-09-20 14:19 ` Guenter Roeck [this message]
2021-09-20 22:19 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210920141919.GA1639673@roeck-us.net \
--to=linux@roeck-us.net \
--cc=W_Armin@gmx.de \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=clopez@igalia.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pali@kernel.org \
--cc=setboolean@icloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox