From: Vadim Pasternak <vadimp@nvidia.com>
To: <linux@roeck-us.net>
Cc: <linux-hwmon@vger.kernel.org>, Vadim Pasternak <vadimp@nvidia.com>
Subject: [PATCH hwmon-next 1/2] hwmon: (mlxreg-fan) Modify PWM connectivity validation
Date: Sun, 26 Sep 2021 08:35:40 +0300 [thread overview]
Message-ID: <20210926053541.1806937-2-vadimp@nvidia.com> (raw)
In-Reply-To: <20210926053541.1806937-1-vadimp@nvidia.com>
Validate PWM connectivity only for additional PWM - "pwm1" is connected
on all systems, while "pwm2" - "pwm4" are optional. Validate
connectivity only for optional attributes by reading of related "pwm{n}"
registers - in case "pwm{n}" is not connected, register value is
supposed to be 0xff.
Signed-off-by: Vadim Pasternak <vadimp@nvidia.com>
---
drivers/hwmon/mlxreg-fan.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/drivers/hwmon/mlxreg-fan.c b/drivers/hwmon/mlxreg-fan.c
index feab9ec6a6ca..8e5cd6991929 100644
--- a/drivers/hwmon/mlxreg-fan.c
+++ b/drivers/hwmon/mlxreg-fan.c
@@ -488,9 +488,14 @@ static int mlxreg_fan_config(struct mlxreg_fan *fan,
return -EINVAL;
}
- err = mlxreg_pwm_connect_verify(fan, data);
- if (err)
- return err;
+ /* Validate if more then one PWM is connected. */
+ if (pwm_num) {
+ err = mlxreg_pwm_connect_verify(fan, data);
+ if (err < 0)
+ return err;
+ else if (!err)
+ continue;
+ }
fan->pwm[pwm_num].reg = data->reg;
fan->pwm[pwm_num].connected = true;
--
2.20.1
next prev parent reply other threads:[~2021-09-26 5:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-26 5:35 [PATCH hwmon-next 0/2] hwmon: (mlxreg-fan) Extend support for multiply PWM Vadim Pasternak
2021-09-26 5:35 ` Vadim Pasternak [this message]
2021-10-08 14:15 ` [PATCH hwmon-next 1/2] hwmon: (mlxreg-fan) Modify PWM connectivity validation Guenter Roeck
2021-09-26 5:35 ` [PATCH hwmon-next 2/2] hwmon: (mlxreg-fan) Support distinctive names per different cooling devices Vadim Pasternak
2021-10-08 14:16 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210926053541.1806937-2-vadimp@nvidia.com \
--to=vadimp@nvidia.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox