From: Guenter Roeck <linux@roeck-us.net>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Ed Brindley <kernel@maidavale.org>,
Denis Pauk <pauk.denis@gmail.com>,
Jean Delvare <jdelvare@suse.com>,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/2] hwmon: (asus_wmi_sensors) fix an array overflow
Date: Tue, 30 Nov 2021 06:43:47 -0800 [thread overview]
Message-ID: <20211130144347.GA279534@roeck-us.net> (raw)
In-Reply-To: <20211130105117.GH5827@kili>
On Tue, Nov 30, 2021 at 01:51:17PM +0300, Dan Carpenter wrote:
> Smatch detects this array overflow:
>
> drivers/hwmon/asus_wmi_sensors.c:569 asus_wmi_configure_sensor_setup()
> error: buffer overflow 'hwmon_attributes' 8 <= 9
>
> The hwmon_attributes[] array should have "hwmon_max" so that it gets
> larger when more attributes are added.
>
> Fixes: 9d07e54a25b8 ("hwmon: (asus_wmi_sensors) Support X370 Asus WMI.")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied.
Thanks,
Guenter
> ---
> drivers/hwmon/asus_wmi_sensors.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/asus_wmi_sensors.c b/drivers/hwmon/asus_wmi_sensors.c
> index 67af15d99396..c80eee874b6c 100644
> --- a/drivers/hwmon/asus_wmi_sensors.c
> +++ b/drivers/hwmon/asus_wmi_sensors.c
> @@ -125,7 +125,7 @@ static enum hwmon_sensor_types asus_data_types[] = {
> [WATER_FLOW] = hwmon_fan,
> };
>
> -static u32 hwmon_attributes[] = {
> +static u32 hwmon_attributes[hwmon_max] = {
> [hwmon_chip] = HWMON_C_REGISTER_TZ,
> [hwmon_temp] = HWMON_T_INPUT | HWMON_T_LABEL,
> [hwmon_in] = HWMON_I_INPUT | HWMON_I_LABEL,
next prev parent reply other threads:[~2021-11-30 14:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-30 10:50 [PATCH 1/2] hwmon: (asus_wmi_ec_sensors) fix array overflow Dan Carpenter
2021-11-30 10:51 ` [PATCH 2/2] hwmon: (asus_wmi_sensors) fix an " Dan Carpenter
2021-11-30 14:43 ` Guenter Roeck [this message]
2021-11-30 14:43 ` [PATCH 1/2] hwmon: (asus_wmi_ec_sensors) fix " Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211130144347.GA279534@roeck-us.net \
--to=linux@roeck-us.net \
--cc=dan.carpenter@oracle.com \
--cc=jdelvare@suse.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kernel@maidavale.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pauk.denis@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox