Re: [PATCH 1/3] hwmon: (asus-ec-sensors) add driver for ASUS EC

kernel test robot
2021-12-17T04:35:48Z

Hi Eugene,

I love your patch! Perhaps something to improve:

[auto build test WARNING on groeck-staging/hwmon-next]
[also build test WARNING on next-20211215]
[cannot apply to v5.16-rc5]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Eugene-Shalygin/hwmon-asus-ec-sensors-add-driver-for-ASUS-EC/20211217-045428
base: https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next
config: ia64-allyesconfig (https://download.01.org/0day-ci/archive/20211217/202112171205.FwhZfLkY-lkp@intel.com/config)
compiler: ia64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/27e7f47121cb02208740ed895a4cf4c7ab5bee63
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Eugene-Shalygin/hwmon-asus-ec-sensors-add-driver-for-ASUS-EC/20211217-045428
git checkout 27e7f47121cb02208740ed895a4cf4c7ab5bee63
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=ia64 SHELL=/bin/bash drivers/hwmon/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

drivers/hwmon/asus-ec-sensors.c: In function 'asus_ec_probe':
>> drivers/hwmon/asus-ec-sensors.c:690:26: warning: ordered comparison of pointer with integer zero [-Wextra]
690 | if (state->board < 0) {
| ^

vim +690 drivers/hwmon/asus-ec-sensors.c

685
686 static int asus_ec_probe(struct platform_device *pdev)
687 {
688 struct ec_sensors_data *state = platform_get_drvdata(pdev);
689
> 690 if (state->board < 0) {
691 return -ENODEV;
692 }
693
694 return 0;
695 }
696

---
0-DAY CI Kernel Test Service, Intel Corporation