From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FE06C433EF for ; Tue, 25 Jan 2022 03:44:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1385201AbiAYDmZ (ORCPT ); Mon, 24 Jan 2022 22:42:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41958 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S3413313AbiAYAit (ORCPT ); Mon, 24 Jan 2022 19:38:49 -0500 Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D9776C061345 for ; Mon, 24 Jan 2022 14:22:07 -0800 (PST) Received: by mail-lj1-x22f.google.com with SMTP id z14so12463956ljc.13 for ; Mon, 24 Jan 2022 14:22:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NJhIoIPY1h73x4Or/3ayh8CG35jR6sYNrRpXzjz3bvI=; b=JQDBTzW6QEl8y4CGc2ZWoibdy3RReZ3ngtEJkzMXyYUN7IZDK4ACY+ZLNS6MWmRNI6 Pl53v0mDipx0uPDYzkJDoS7ldxEZfI/q9YjVQWbUG9xx0kaLfMwPYHNZZuiZR3kEoK7t 0SN0qBWy06BfoE6qcdslTr+dHWzyx6QbcrlIGoA5E014M8DPEqr0xKgBFuyWuUdsQmTF Q22wOWorWelA58s5+Iafnn2ZBFIRJQ7KzjQBPWL0f+TMB8VuBP9/ueOFo1D5jy27omx8 ltQCLIixQk+EbqiP6snFdoRKB9umfPpFRQRcHnpzakBIS7pL4TZaUIbHZn3vFa+20Pru kChQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NJhIoIPY1h73x4Or/3ayh8CG35jR6sYNrRpXzjz3bvI=; b=rlMS69gOpGGg7zd2o9H6klR/cqeYaPxpyEYssvMAKLt5OAlhLgUGU3+oCbnSkrkL4c MhcLs89WsOLgOn+9s07zGJxPjtKKpBYTcsAylcTr4ANqN55MRTOQNemvQslRuSyju14M p3DYuscMZXZ8mwUMKOfHbmiATkB4nEK0SMuq7dbMI0lSB0+CQpe9YUNbCOlOtZSrBDcM +tsWveS+0P5WreEmsybpsatFG4K+BMufIMlnRVIcDlPKGx8KXFicKbLsAfXNOY868uwP j2oF3lFxmoz1+HGAOmzoi7EzNd94zKRRsOXc8HJY+jDloE0JaBZSpdFESZVDvgMKUx1z SyNg== X-Gm-Message-State: AOAM53247Up+iMMtZY1eOQJiIOLpc/XlKBhFcvGW78pZSi8OAvWdbHri r5/N2UgKNRUbX3zHZWs7ShI= X-Google-Smtp-Source: ABdhPJzpJnOzPXrD0ey4Fx1n3PQGe0YNFdiqvEiUSHlgK3VKvEVXe0+UeP9p7L/zu4itSF/qP94Y8A== X-Received: by 2002:a2e:96c5:: with SMTP id d5mr12474774ljj.527.1643062925996; Mon, 24 Jan 2022 14:22:05 -0800 (PST) Received: from netbook-debian ([94.179.21.60]) by smtp.gmail.com with ESMTPSA id h15sm1297139lfk.20.2022.01.24.14.22.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Jan 2022 14:22:05 -0800 (PST) Date: Tue, 25 Jan 2022 00:21:57 +0200 From: Denis Pauk To: Guenter Roeck Cc: Hardware Monitoring , Jean Delvare , Bernhard Seibold , =?UTF-8?B?UGF3ZcWC?= Marciniak Subject: Re: [PATCH] hwmon: (nct6775) Fix crash in clear_caseopen Message-ID: <20220125002157.0d6823d1@netbook-debian> In-Reply-To: <20220124023248.475734-1-linux@roeck-us.net> References: <20220124023248.475734-1-linux@roeck-us.net> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org On Sun, 23 Jan 2022 18:32:48 -0800 Guenter Roeck wrote: > Pawe=C5=82 Marciniak reports the following crash, observed when clearing > the chassis intrusion alarm. >=20 > BUG: kernel NULL pointer dereference, address: 0000000000000028 > PGD 0 P4D 0 > Oops: 0000 [#1] PREEMPT SMP PTI > CPU: 3 PID: 4815 Comm: bash Tainted: G S > 5.16.2-200.fc35.x86_64 #1 Hardware name: To Be Filled By O.E.M. To Be > Filled By O.E.M./Z97 Extreme4, BIOS P2.60A 05/03/2018 RIP: > 0010:clear_caseopen+0x5a/0x120 [nct6775] Code: 68 70 e8 e9 32 b1 e3 > 85 c0 0f 85 d2 00 00 00 48 83 7c 24 ... RSP: 0018:ffffabcb02803dd8 > EFLAGS: 00010246 RAX: 0000000000000000 RBX: 0000000000000002 RCX: > 0000000000000000 RDX: ffff8e8808192880 RSI: 0000000000000000 RDI: > ffff8e87c7509a68 RBP: 0000000000000000 R08: 0000000000000001 R09: > 000000000000000a R10: 000000000000000a R11: f000000000000000 R12: > 000000000000001f R13: ffff8e87c7509828 R14: ffff8e87c7509a68 R15: > ffff8e88494527a0 FS: 00007f4db9151740(0000) > GS:ffff8e8ebfec0000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 > ES: 0000 CR0: 0000000080050033 CR2: 0000000000000028 CR3: > 0000000166b66001 CR4: 00000000001706e0 Call Trace: > > kernfs_fop_write_iter+0x11c/0x1b0 > new_sync_write+0x10b/0x180 > vfs_write+0x209/0x2a0 > ksys_write+0x4f/0xc0 > do_syscall_64+0x3b/0x90 > entry_SYSCALL_64_after_hwframe+0x44/0xae >=20 > The problem is that the device passed to clear_caseopen() is the hwmon > device, not the platform device, and the platform data is not set in > the hwmon device. Store the pointer to sio_data in struct > nct6775_data and get if from there if needed. >=20 > Fixes: 2e7b9886968b ("hwmon: (nct6775) Use superio_*() function > pointers in sio_data.") Cc: Denis Pauk > Cc: Bernhard Seibold > Reported-by: Pawe=C5=82 Marciniak > Signed-off-by: Guenter Roeck > --- > drivers/hwmon/nct6775.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/hwmon/nct6775.c b/drivers/hwmon/nct6775.c > index fd3f91cb01c6..098d12b9ecda 100644 > --- a/drivers/hwmon/nct6775.c > +++ b/drivers/hwmon/nct6775.c > @@ -1175,7 +1175,7 @@ static inline u8 in_to_reg(u32 val, u8 nr) > =20 > struct nct6775_data { > int addr; /* IO base of hw monitor block */ > - int sioreg; /* SIO register address */ > + struct nct6775_sio_data *sio_data; > enum kinds kind; What do you think about remove kind field also from struct nct6775_data? Code has copy of this field inside of the struct nct6775_sio_data.=20 > const char *name; > =20 > @@ -3559,7 +3559,7 @@ clear_caseopen(struct device *dev, struct > device_attribute *attr, const char *buf, size_t count) > { > struct nct6775_data *data =3D dev_get_drvdata(dev); > - struct nct6775_sio_data *sio_data =3D dev_get_platdata(dev); > + struct nct6775_sio_data *sio_data =3D data->sio_data; > int nr =3D to_sensor_dev_attr(attr)->index - > INTRUSION_ALARM_BASE; unsigned long val; > u8 reg; > @@ -3967,7 +3967,7 @@ static int nct6775_probe(struct platform_device > *pdev) return -ENOMEM; > =20 > data->kind =3D sio_data->kind; > - data->sioreg =3D sio_data->sioreg; > + data->sio_data =3D sio_data; > =20 > if (sio_data->access =3D=3D access_direct) { > data->addr =3D res->start; Tested-by: Denis Pauk Best regards, Denis.