From: Guenter Roeck <linux@roeck-us.net>
To: Armin Wolf <W_Armin@gmx.de>
Cc: hdegoede@redhat.com, jdelvare@suse.com,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] hwmon: (core) Add support for pwm auto channels attribute
Date: Thu, 24 Feb 2022 18:09:13 -0800 [thread overview]
Message-ID: <20220225020913.GA1976093@roeck-us.net> (raw)
In-Reply-To: <20220224061210.16452-2-W_Armin@gmx.de>
On Thu, Feb 24, 2022 at 07:12:09AM +0100, Armin Wolf wrote:
> pwm[1-*]_auto_channels_temp is documented as an official
> hwmon sysfs attribute, yet there is no support for it in
> the new with_info-API. Fix that.
>
> Signed-off-by: Armin Wolf <W_Armin@gmx.de>
Applied to hwmon-next.
Thanks,
Guenter
> ---
> drivers/hwmon/hwmon.c | 1 +
> include/linux/hwmon.h | 2 ++
> 2 files changed, 3 insertions(+)
>
> --
> 2.30.2
>
> diff --git a/drivers/hwmon/hwmon.c b/drivers/hwmon/hwmon.c
> index 0d6c6809f26c..989e2c8496dd 100644
> --- a/drivers/hwmon/hwmon.c
> +++ b/drivers/hwmon/hwmon.c
> @@ -604,6 +604,7 @@ static const char * const hwmon_pwm_attr_templates[] = {
> [hwmon_pwm_enable] = "pwm%d_enable",
> [hwmon_pwm_mode] = "pwm%d_mode",
> [hwmon_pwm_freq] = "pwm%d_freq",
> + [hwmon_pwm_auto_channels_temp] = "pwm%d_auto_channels_temp",
> };
>
> static const char * const hwmon_intrusion_attr_templates[] = {
> diff --git a/include/linux/hwmon.h b/include/linux/hwmon.h
> index fad1f1df26df..eba380b76d15 100644
> --- a/include/linux/hwmon.h
> +++ b/include/linux/hwmon.h
> @@ -332,12 +332,14 @@ enum hwmon_pwm_attributes {
> hwmon_pwm_enable,
> hwmon_pwm_mode,
> hwmon_pwm_freq,
> + hwmon_pwm_auto_channels_temp,
> };
>
> #define HWMON_PWM_INPUT BIT(hwmon_pwm_input)
> #define HWMON_PWM_ENABLE BIT(hwmon_pwm_enable)
> #define HWMON_PWM_MODE BIT(hwmon_pwm_mode)
> #define HWMON_PWM_FREQ BIT(hwmon_pwm_freq)
> +#define HWMON_PWM_AUTO_CHANNELS_TEMP BIT(hwmon_pwm_auto_channels_temp)
>
> enum hwmon_intrusion_attributes {
> hwmon_intrusion_alarm,
next prev parent reply other threads:[~2022-02-25 2:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-24 6:12 [PATCH v2 0/2] hwmon: (sch5627) Add pwmX_auto_channels_temp attributes Armin Wolf
2022-02-24 6:12 ` [PATCH v2 1/2] hwmon: (core) Add support for pwm auto channels attribute Armin Wolf
2022-02-25 2:09 ` Guenter Roeck [this message]
2022-02-24 6:12 ` [PATCH v2 2/2] hwmon: (sch5627) Add pwmX_auto_channels_temp support Armin Wolf
2022-02-25 2:10 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220225020913.GA1976093@roeck-us.net \
--to=linux@roeck-us.net \
--cc=W_Armin@gmx.de \
--cc=hdegoede@redhat.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox