From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2BF2C433EF for ; Mon, 25 Apr 2022 10:01:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238096AbiDYKEE (ORCPT ); Mon, 25 Apr 2022 06:04:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36270 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241552AbiDYKDm (ORCPT ); Mon, 25 Apr 2022 06:03:42 -0400 Received: from smtp2.axis.com (smtp2.axis.com [195.60.68.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 399ED627D; Mon, 25 Apr 2022 03:00:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; q=dns/txt; s=axis-central1; t=1650880837; x=1682416837; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=2TQZYCx5ikLMtqq9rZGikO1te9HCqCd3K7Ahb1z4JPg=; b=o5TQ2lyp7C6NaGzOBeBg1iA8D4ROI/3VJWc3zFIQgocBLlkQBDpF4z6/ ip4hT2Vhd1sXrXxHHhz5tInCs5MQrx8+BNf4SJTNO0scmA7J8PRM1HOCU 3g3vIibDZ/jsI8dX4HcGP0/FA3k+TmIWq525N5RicAu6n3n+duwlVeXZO gevAaostmxdl1o0dSDlhFP62eN0q9DO7y1csIObasHOrQ0k5+XDLxzxt5 b7i2H7e0f1hVExEb9zGOI0SU33HCLDjKRcgYg0ETLlFfplZh292VXzaUF xAlLN+I/E1updt88Gbc0elw41TiudGkTlNyp3RZBIQxga6J3TzC2S0mAg Q==; From: Camel Guo To: Guenter Roeck , Jean Delvare CC: Camel Guo , , , Subject: [PATCH] hwmon: (tmp401) Fix incorrect return value of tmp401_init_client Date: Mon, 25 Apr 2022 12:00:19 +0200 Message-ID: <20220425100019.562781-1-camel.guo@axis.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org When ti,n-factor, ti,beta-compentation are not defined in devicetree, of_property_read_u32|s32 returns -EINVAL. In this case, tmp401_init_client should return 0 instead of simply pass ret to its caller. Fixes: c825ca044988 ("hwmon: (tmp401) Add support of three advanced features") Signed-off-by: Camel Guo --- drivers/hwmon/tmp401.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwmon/tmp401.c b/drivers/hwmon/tmp401.c index 8f49da997367..a58a2f31a07e 100644 --- a/drivers/hwmon/tmp401.c +++ b/drivers/hwmon/tmp401.c @@ -604,7 +604,7 @@ static int tmp401_init_client(struct tmp401_data *data) return ret; } - return ret; + return 0; } static int tmp401_detect(struct i2c_client *client, -- 2.30.2