From: Guenter Roeck <linux@roeck-us.net>
To: Eugene Shalygin <eugene.shalygin@gmail.com>
Cc: Jean Delvare <jdelvare@suse.com>,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: (asus-ec-sensors) fix Formula VIII definition
Date: Tue, 17 May 2022 05:46:40 -0700 [thread overview]
Message-ID: <20220517124640.GA3400378@roeck-us.net> (raw)
In-Reply-To: <20220517080508.1910953-1-eugene.shalygin@gmail.com>
On Tue, May 17, 2022 at 10:05:08AM +0200, Eugene Shalygin wrote:
> The ROG CROSSHAIR VIII FORMULA board has the same sensors as the
> CROSSHAIR VIII HERO [1] thus let's join their definitions which adds
> missing sensors for Formula.
>
> [1] https://github.com/LibreHardwareMonitor/LibreHardwareMonitor/pull/740
>
> Signed-off-by: Eugene Shalygin <eugene.shalygin@gmail.com>
Applied.
Thanks,
Guenter
> ---
> drivers/hwmon/asus-ec-sensors.c | 12 ++----------
> 1 file changed, 2 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/hwmon/asus-ec-sensors.c b/drivers/hwmon/asus-ec-sensors.c
> index 611e897429b1..57e11b2bab74 100644
> --- a/drivers/hwmon/asus-ec-sensors.c
> +++ b/drivers/hwmon/asus-ec-sensors.c
> @@ -54,7 +54,7 @@ static char *mutex_path_override;
> /* ACPI mutex for locking access to the EC for the firmware */
> #define ASUS_HW_ACCESS_MUTEX_ASMX "\\AMW0.ASMX"
>
> -#define MAX_IDENTICAL_BOARD_VARIATIONS 2
> +#define MAX_IDENTICAL_BOARD_VARIATIONS 3
>
> /* Moniker for the ACPI global lock (':' is not allowed in ASL identifiers) */
> #define ACPI_GLOBAL_LOCK_PSEUDO_PATH ":GLOBAL_LOCK"
> @@ -257,17 +257,9 @@ static const struct ec_board_info board_info[] = {
> .mutex_path = ASUS_HW_ACCESS_MUTEX_ASMX,
> .family = family_amd_500_series,
> },
> - {
> - .board_names = {"ROG CROSSHAIR VIII FORMULA"},
> - .sensors = SENSOR_SET_TEMP_CHIPSET_CPU_MB |
> - SENSOR_TEMP_T_SENSOR | SENSOR_TEMP_VRM |
> - SENSOR_FAN_CPU_OPT | SENSOR_FAN_CHIPSET |
> - SENSOR_CURR_CPU | SENSOR_IN_CPU_CORE,
> - .mutex_path = ASUS_HW_ACCESS_MUTEX_ASMX,
> - .family = family_amd_500_series,
> - },
> {
> .board_names = {
> + "ROG CROSSHAIR VIII FORMULA"
> "ROG CROSSHAIR VIII HERO",
> "ROG CROSSHAIR VIII HERO (WI-FI)",
> },
prev parent reply other threads:[~2022-05-17 12:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-17 8:05 [PATCH] hwmon: (asus-ec-sensors) fix Formula VIII definition Eugene Shalygin
2022-05-17 12:46 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220517124640.GA3400378@roeck-us.net \
--to=linux@roeck-us.net \
--cc=eugene.shalygin@gmail.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox